Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downloaded seed phrase backup named "MetaMask Secret Backup Phrase" #6275

Closed
kjozwiak opened this issue Oct 2, 2019 · 2 comments
Closed

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Oct 2, 2019

Description

When downloading/backing up the seed phrase via downloading, the file that's saved is named MetaMask Secret Backup Phrase.txt but should be named Brave Secret Backup Phrase.txt.

Steps to Reproduce

  1. open brave and create a wallet via brave://wallet
  2. select the Download phrase under Secret Backup Phrase

Screen Shot 2019-10-02 at 2 22 18 AM

Actual result:

Screen Shot 2019-10-02 at 2 03 44 AM

Expected result:

Backup that's being downloaded should be named Brave Secret Backup Phrase.txt and not MetaMask Secret Backup Phrase.txt.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A (not released yet)
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @ryanml @bbondy @rebron @tomlowenthal @brave/legacy_qa

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 2, 2019
@kjozwiak
Copy link
Member Author

kjozwiak commented Oct 2, 2019

Fixed via #5694. Going to close this one off and use this as the main issue for QA verification as it includes STR and examples 👍

@srirambv
Copy link
Contributor

srirambv commented Oct 2, 2019

Verification passed on

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux
  • Verified download seed phrase backup name is Crypto Wallets Secret Backup Phrase.txt
  • Verified on component version 1.0.9
    image

Verification passed on

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1903 (Build 18362.30)
  • Verified download seed phrase backup name is Crypto Wallets Secret Backup Phrase.txt
  • Verified on component version 1.0.9
    image

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Used Crypto Wallets - Version: 1.0.9 and went through the following:

  • ensured Crypto Wallets Secret Backup Phrase.txt was being saved when backing up seed phrase on initial wallet creation
  • ensured Brave Seed Words.csv was being saved via Settings -> Security & Privacy -> Reveal Seed Words

Screen Shot 2019-10-02 at 7 17 03 PM

Screen Shot 2019-10-02 at 7 17 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants