P3A follow up

[bsclifton]

Description

The implementation of Privacy Preserving Product Analytics (P3A) landed with brave/brave-core#3242

More details on our blog here:
https://brave.com/privacy-preserving-product-analytics-p3a/

Detailed list of the questions here:
https://github.com/brave/brave-browser/wiki/P3A

This was a larger scope project and there was some good feedback and discussions in the pull request. This issue is to track asks that were made there and to make sure we follow through with those asks

P1 Issues

• Probably wrong capturing of balance https://github.com/brave/brave-antibot/commit/eb1692afeb0e9de4e6007d721045d07806fb9e1a#r34791133
• Initial implementation of P3A (Privacy-Preserving Product Analytics) brave-core#3242 (comment)
• Follow up on mention of tests - Initial implementation of P3A (Privacy-Preserving Product Analytics) brave-core#3242 (comment)

P2 Issues

• Discussion about LedgerClient::RecordMetric generic metric interface - Initial implementation of P3A (Privacy-Preserving Product Analytics) brave-core#3242 (comment)
• Convert BraveShieldsOnShieldsPanelShownFunction to a generic P3A extension API call - Initial implementation of P3A (Privacy-Preserving Product Analytics) brave-core#3242 (comment)
• Code organization comment - Initial implementation of P3A (Privacy-Preserving Product Analytics) brave-core#3242 (comment)
• Refactoring / code splitting comment - Initial implementation of P3A (Privacy-Preserving Product Analytics) brave-core#3242 (comment)
• Make BraveP3AService non-refcounted
• Rename prochlo -> pyxis

[iefremov]

Crossed out some completed items and added another one

[bsclifton]

@iefremov can we close this issue out and create specific issues for the must have items (that are still relevant, called out above under P1 / P2)?

[rillian]

It looks like this has been covered by specific implementation issues with tracking through @mattmcalister's spreadsheet and the project board.