Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve context of string (subhead) for BR Wallet Verification Dialog #6537

Closed
bradleyrichter opened this issue Oct 18, 2019 · 3 comments · Fixed by brave/brave-core#3739
Closed

Improve context of string (subhead) for BR Wallet Verification Dialog #6537

bradleyrichter opened this issue Oct 18, 2019 · 3 comments · Fixed by brave/brave-core#3739
Assignees
@bradleyrichter
Labels
feature/rewards feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.0.0 - Release

Comments

@bradleyrichter
Copy link

old string (subhead)

image

text: Verification is not necessary to earn rewards for creator contributions

New subhead text:
Verification is not necessary to contribute your rewards to creators
@bradleyrichter bradleyrichter added needs-text-change This change requires some careful wording. feature/user-interface All UI related 1.0-suggestion labels Oct 18, 2019
@ryanml ryanml added this to the 0.73.x - Nightly milestone Oct 18, 2019
@bradleyrichter bradleyrichter mentioned this issue Oct 18, 2019
Merged
32 tasks
@NejcZdovc NejcZdovc assigned bradleyrichter and unassigned rebron and ryanml Oct 18, 2019
@NejcZdovc NejcZdovc added QA/Yes and removed needs-text-change This change requires some careful wording. labels Oct 18, 2019
@rebron rebron added 1.0 and removed 1.0-suggestion labels Oct 22, 2019
This was referenced Oct 23, 2019
Merged
Merged
@LaurenWags
Copy link
Member

Adding QA/Blocked label as this has not yet been uplifted to 0.71.x

@LaurenWags
Copy link
Member

Removing QA/Blocked label as this has been uplifted to 0.71.x and is available in 0.71.105 and above.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 30, 2019 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.71.105 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)
  • Confirmed updated wording in UI is expected (note - it is slightly different than above and in the PR)
  • Confirmed updated wording is shown when accessing modal from brave://rewards page Verify Wallet button, Add Funds button, Withdraw Funds button, and verify link in wallet panel footer.
  • Confirmed updated wording is shown when accessing modal from panel Verify Wallet button and Add Funds button

Screen Shot 2019-10-30 at 10 13 44 AM

Verification passed on

Brave 0.71.105 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS
  • Verified updated wording in UI is expected
  • Verified updated wording is shown when accessing modal from brave://rewards page Verify Wallet button, Add Funds button, Withdraw Funds button, and verify link in wallet panel footer.
  • Verified updated wording is shown when accessing modal from panel Verify Wallet button and Add Funds button

image

Verification passed on

Brave 0.71.106 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified updated wording in UI is expected
  • Verified updated wording is shown when accessing modal from brave://rewards page Verify Wallet button, Add Funds button, Withdraw Funds button, and verify link in wallet panel footer.
  • Verified updated wording is shown when accessing modal from panel Verify Wallet button and Add Funds button

image

@kjozwiak kjozwiak mentioned this issue Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bradleyrichter bradleyrichter

Labels
feature/rewards feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging a pull request may close this issue.

Improve context of string language bradleyrichter/brave-core
7 participants
@rebron @ryanml @NejcZdovc @bradleyrichter @LaurenWags @btlechowski @GeetaSarvadnya