Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

details translation missing in Rewards panel #6577

Closed
LaurenWags opened this issue Oct 22, 2019 · 3 comments · Fixed by brave/brave-core#3751
Closed

details translation missing in Rewards panel #6577

LaurenWags opened this issue Oct 22, 2019 · 3 comments · Fixed by brave/brave-core#3751

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 22, 2019

Description

On the Brave Rewards panel the translation for 'Details' is missing.

Steps to Reproduce

  1. Clean profile on staging
  2. Enable Rewards
  3. Claim a Grant
  4. View panel

Actual result:

Screen Shot 2019-10-22 at 8 59 04 AM

Note - this is working as expected on brave://rewards page.

Expected result:

Should have a translated value - it used to say 'Grants' but I think it is changing so it will say 'Details' now as it does on brave://rewards page.
Screen Shot 2019-10-22 at 9 19 29 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.73.17 Chromium: 78.0.3904.50 (Official Build) nightly (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no (0.70.120
  • Can you reproduce this issue with the beta channel? no (0.71.101)
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @mandar-brave

@NejcZdovc
Copy link
Contributor

@ryanml will this be fixed with BAT points PR?

@ryanml
Copy link
Contributor

ryanml commented Oct 22, 2019

@NejcZdovc it will yes, I will link the issue

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 4, 2019

Verification passed on

Brave 0.71.108 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
    BR panel
    image
    Brave rewards page
    image

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description
    BR panel
    image
    Brave rewards page
    image

Verified passed with

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

Screen Shot 2019-11-04 at 10 56 45 AM

Screen Shot 2019-11-04 at 10 57 03 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment