Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave crashes when paywalls raised on Washington Post when PrivacyBadger (or other paywall extensions) installed #6735

Closed
tbpassin opened this issue Nov 3, 2019 · 6 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. crash feature/extensions OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@tbpassin
Copy link

tbpassin commented Nov 3, 2019

Description

With Brave V 0.70.122 and the previous version on Windows 10 v1903, opening www.washingtonpost.com consistently crashes my installation, including after a re-install. The page appears to open correctly, but then the browser silently closes.

Steps to Reproduce

  1. Type www.washingtonpost.com into the URL bar.
  2. Observe the page open and apparently display.
  3. Observe the browser close without any message.

Actual result:

Expected result:

The page should open and stay readable.

Reproduces how often:

Every time on my system.

Brave version (brave://version info)

0.70.122 Chromium: 78.0.3904.87 (Official Build) (64-bit)

Revision | 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS | Windows 10 OS Version 1903 (Build 18362.418)

Version/Channel Information:

NA

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    NA
  • Can you reproduce this issue with the dev channel?
    NA
  • Can you reproduce this issue with the nightly channel?
    NA

Other Additional Information:

Same thing happened on the previous release, but before that behavior was normal.

  • Does the issue resolve itself when disabling Brave Shields?
    Untried.
  • Does the issue resolve itself when disabling Brave Rewards?
    Not in use.
  • Is the issue reproducible on the latest version of Chrome?
    No problem on "Version 78.0.3904.87 (Official Build) (64-bit)"

Miscellaneous Information:

@bsclifton
Copy link
Member

@tbpassin do you have any extensions installed? Specifically, any that are blocking paywalls?

There was a recent issue report where an extension did break and cause a crash. Let us know 😄

@bsclifton bsclifton added crash needs-investigation A bug not 100% confirmed/fixed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Nov 5, 2019
@tbpassin
Copy link
Author

tbpassin commented Nov 5, 2019

@tbpassin do you have any extensions installed? Specifically, any that are blocking paywalls?

There was a recent issue report where an extension did break and cause a crash. Let us know 😄

Ha! It stopped quitting after I disabled Privacy Badger. Thanks for the suggestion - I forgot I had added any extensions. I don't know that a paywall was involved, since I can ordinarily browse the Post without logging in on another browser with a javascript blocker and Privacy Badger (specifically Vivaldi). Well, maybe it started with a version update to Privacy Badger; I probably wouldn't have remembered.

@tbpassin tbpassin closed this as completed Nov 5, 2019
@bsclifton
Copy link
Member

@tbpassin thanks for the update! 😄

Definitely seems like a bug on our side too - even if the extension is raising the error. Let me re-open the issue and reword things a bit 😄

@bsclifton bsclifton reopened this Nov 5, 2019
@bsclifton bsclifton changed the title Brave V 0.70.122 crashes opening Washington Post Brave crashes when paywalls raised on Washington Post when PrivacyBadger (or other paywall extensions) installed Nov 5, 2019
@bsclifton bsclifton added feature/extensions and removed needs-more-info The report requires more detail before we can decide what to do with this issue. needs-investigation A bug not 100% confirmed/fixed labels Nov 5, 2019
@tbpassin
Copy link
Author

tbpassin commented Nov 5, 2019

In case this might be helpful - the crash happens after a few seconds delay. The page seems to load fully and display normally, then after another second or several seconds, the browser closes with no message displayed. I haven't found any events in the Windows event logs that seem related.

Also, I added washingtonpost.com to Privacy Badger's whitelist, but that didn't change the behavior. On Vivaldi, with the same version of Privacy Badger, I don't have this problem. I'd rather use Brave, though.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 20, 2019
@iefremov
Copy link
Contributor

appears to be fixed, @tbpassin could you recheck?

@iefremov iefremov added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Feb 16, 2021
@tbpassin
Copy link
Author

I have checked using

Version 1.20.103 Chromium: 88.0.4324.152 (Official Build) (64-bit)

And even after installing Privacy Badger I no longer get crashes on the Washington Post page.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. crash feature/extensions OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

4 participants