Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tor switch option in settings #6808

Closed
simonhong opened this issue Nov 7, 2019 · 1 comment · Fixed by brave/brave-core#4046
Closed

Add tor switch option in settings #6808

simonhong opened this issue Nov 7, 2019 · 1 comment · Fixed by brave/brave-core#4046

Comments

@simonhong
Copy link
Member

simonhong commented Nov 7, 2019

Test plan

See brave/brave-core#4046

Description

That setting can enable/disable tor on runtime.
After changing that option, new option will be in effect after restarting.

@btlechowski
Copy link

btlechowski commented Feb 12, 2020

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4046
Tor enabled by default
image
Tor off
image
Task manager after closing Tor window
image

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

Tor off - When Private window with Tor is off New private window with tor option is not available in Normal and Private tab app menu
image

image

No tor utility process is running in task manager when TOR option is disabled and closed all tor tabs
image

Verified passed with

Brave 1.4.85 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified test plan from Add setting option for disabling tor component brave-core#4046
  • In addition to the test plan above, confirmed the following items when Tor is off in brave://settings/extensions
    • the 'New Private Window with Tor' option does not show in the hamburger menu on Normal, Private, and Guest windows.
    • keyboard shortcut for Tor window (cmd+opt+N on macOS) does not open a Tor window.
    • New Private Window with Tor is removed from context menus when right clicking on a link

Tor toggle off - When Private Window with Tor is off New Private Window with Tor option is not available in Normal, Private and Guest tab hamburger menus
Screen Shot 2020-02-12 at 2 40 18 PM
Screen Shot 2020-02-12 at 2 40 29 PM
Screen Shot 2020-02-12 at 2 40 39 PM

Confirmed no Tor utility process is running in task manager when Tor option is disabled and all open Tor windows have been closed:
Screen Shot 2020-02-12 at 2 39 57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment