Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right click option for Private Window - consider updating UK English capitalization - follow up to 6872 #6891

Closed
LaurenWags opened this issue Nov 12, 2019 · 3 comments

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #6872

When right clicking on a link to get context menu, consider capitalizing 'Link' and 'Window' to match other options displayed (also would match US English).

Steps to Reproduce

  1. Clean profile UK English
  2. Navigate to a site with a link.
  3. Right click on link.

Actual result:

'Link' and 'Window' for 3rd option are not capitalized but they are capitalized in adjacent options.
Screen Shot 2019-11-12 at 10 15 33 AM

Expected result:

Screen Shot 2019-11-12 at 10 32 31 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @petemill

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 12, 2019

Verified in Windows 10 x64 - 0.71.115 - In windows p and w are small letters in both the Hamburger menu and context menu and the behavior is the same in Chrome as well. Looks like macOS specific issue

Hamburger menu:
image

Context menu
image

@bsclifton
Copy link
Member

Fixed in 0.71 with brave/brave-core#3982

@LaurenWags LaurenWags added this to the 0.71.x - Release milestone Nov 12, 2019
@LaurenWags
Copy link
Member Author

Verified passed with

Brave 0.71.116 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

Screen Shot 2019-11-12 at 6 04 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants