Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(follow up) after migrating some widevine prefs from profile to local state #7000

Open
simonhong opened this issue Nov 19, 2019 · 0 comments
Open

(follow up) after migrating some widevine prefs from profile to local state #7000

simonhong opened this issue Nov 19, 2019 · 0 comments
Assignees
@simonhong
Labels
dev-concern plugin/Widevine

Comments

@simonhong
Copy link
Member

simonhong commented Nov 19, 2019 •
edited
Loading

This is f/u issue from #6747.

  • Migrate kAskWidevineInstall pref to local state
  • Hide don't ask widevine prompt options from settings page when widevine is disabled

See the reason why this pref is not migrated together in the description of brave/brave-core#3959

There is one more Widevine related pref. It's kAskWidevineInstall.
It would be good to migrate kAskWidevineInstall to local prefs also.
But left as-is in profile prefs also seems fine.
After Widevine is installed that prefs doesn't have much meaning and if not just click once to dont ask is sufficient. Also, it is convinient to implement settings option with profile prefs.
@simonhong simonhong self-assigned this Nov 19, 2019
@simonhong simonhong changed the title Migrate kAskWidevineInstall pref to local state. F/u after migrating some widevine prefs from profile to local state kAskWidevineInstall pref to local state. Nov 19, 2019
@simonhong simonhong changed the title F/u after migrating some widevine prefs from profile to local state kAskWidevineInstall pref to local state. F/u after migrating some widevine prefs from profile to local state Nov 19, 2019
@bsclifton bsclifton changed the title F/u after migrating some widevine prefs from profile to local state (follow up) after migrating some widevine prefs from profile to local state Nov 19, 2019
@rebron rebron moved this to P5 backlog in Settings May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
dev-concern plugin/Widevine
Projects
Settings
Status: P5 backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rebron @simonhong