Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon uses chromium icon in taskbar when you install via .deb file #73

Closed
bbondy opened this issue Feb 11, 2018 · 11 comments
Closed

Icon uses chromium icon in taskbar when you install via .deb file #73

bbondy opened this issue Feb 11, 2018 · 11 comments

Comments

@bbondy
Copy link
Member

bbondy commented Feb 11, 2018

No description provided.

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented Feb 16, 2018

I cannot see the issue.
I saw a similar issue, if I take clean Ubuntu 16 and install with sudo dpkg -i brave-amd64.deb, it says libappindicator1 is required.
If I just run Brave, the icon is not displayed, neither chrome's nor brave's. It is required to install deps with sudo apt-get -f install. The original chrome.deb has the same behavior.

Here is a deb I have used https://drive.google.com/file/d/1eXD-8x0-Vc314cswU-qe8NOo18AKT5te/view?usp=sharing .

@srirambv
Copy link
Contributor

@AlexeyBarabash
Copy link
Contributor

@srirambv
This is how it looks until I run sudo apt-get -f install
screenshot from 2018-02-16 15-44-40
screenshot from 2018-02-16 15-43-47

@srirambv
Copy link
Contributor

Its quite different. But on Windows i see the error icon on taskbar (sometimes) but right click on it brings back brave icon. But window peek always shows the error icon mention in the other issue

@AlexeyBarabash
Copy link
Contributor

Runs good on Linux Mint 18.3 Cinnamon.
screenshot from 2018-02-16 17-15-15
screenshot from 2018-02-16 17-14-51
screenshot from 2018-02-16 17-14-28

@bbondy
Copy link
Member Author

bbondy commented Feb 21, 2018

Does it share the same icon if you also install Chromium?

@AlexeyBarabash
Copy link
Contributor

If I install Chromium (not Google Chrome), I can see the issue:
image

@bbondy
Copy link
Member Author

bbondy commented Feb 21, 2018

So for example on windows installer I had to modify registry entries to point to our own unique UUIDs to fix a similar problem.

@AlexeyBarabash
Copy link
Contributor

Thanks. Something similar must be on Linux.

@AlexeyBarabash
Copy link
Contributor

This should be fixed by brave/brave-core#45.
The issue appeared on all Linux versions which are using Gnome environment.

@bbondy bbondy closed this as completed Mar 14, 2018
@bbondy bbondy added this to the Releasable builds milestone Jun 14, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@srirambv
Copy link
Contributor

srirambv commented Sep 21, 2018

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • New install via .deb file shows correct Brave icon
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants