Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dismissed Rewards notifications come back after browser restart #7313

Closed
LaurenWags opened this issue Dec 10, 2019 · 4 comments
Closed

dismissed Rewards notifications come back after browser restart #7313

LaurenWags opened this issue Dec 10, 2019 · 4 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.

Comments

@LaurenWags
Copy link
Member

Description

I have 5 Rewards notifications that I dismiss from the BAT logo. However, once I restart my browser to receive an update, the 5 notifications are back. Again, I can dismiss them but once I restart they show up again.

Steps to Reproduce

Not sure. I don't even know why there was a problem processing my contribution.

Actual result:

In the gif below, I had already dismissed the notifications. I then relaunched Nightly (it takes some time, I have 100's of tabs 😄). Then on relaunch, the notifications are back. So I dismissed them again. Relaunch again and you can see the notifications have magically returned.

magicallyreappearingnotifications

Expected result:

Notifications should not reappear once dismissed.

Reproduces how often:

easily

Brave version (brave://version info)

I experienced it on Nightly since that's my daily driver

Brave 1.4.16 Chromium: 79.0.3945.74 (Official Build) nightly (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? unsure
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc

This is my personal profile, not a test profile, so I will not be posting it to GH. If you need specific info from my ledger_state or another file let me know.

@NejcZdovc
Copy link
Contributor

@LaurenWags is this still a problem?

@NejcZdovc NejcZdovc added needs-more-info The report requires more detail before we can decide what to do with this issue. and removed needs-investigation A bug not 100% confirmed/fixed bug labels Apr 10, 2020
@LaurenWags
Copy link
Member Author

yes, happens to me each time I restart my current profile (Dev 1.8.66 currently). I can't reproduce it on a clean profile, so something in my profile is probably jacked.

@bsclifton
Copy link
Member

@LaurenWags just about time for the yearly checkup 😂 Is this still happening for you?

The notices can definitely be profile specific. There's a JSON blob in there with each of them (if you're able to repro, you can share w/ me and I can help narrow down). I got into this same situation too and had over 50 un-dismissible messages 😛

@LaurenWags
Copy link
Member Author

@bsclifton unfortunately that profile is long gone 😭 I'll close this issue and reopen if I see it happening again 👍🏻

@LaurenWags LaurenWags added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed QA/Yes feature/rewards needs-more-info The report requires more detail before we can decide what to do with this issue. labels Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
Projects
None yet
Development

No branches or pull requests

3 participants