Sync polls S3 twice a minute when there are no activity for 24 hours

[AlexeyBarabash]

Description

If Brave desktop browser has sync enabled, but there were no changes on synced objects, then data gets queried from AWS S3 storage and not from SQS.

This happens because the last bookmark operation time is may be older than 24 hours, and we pass the last record timestampt, so (currentTime - startAtToCheck) > 24 hours at https://github.com/brave/sync/blob/staging/client/requestUtil.js#L273

Steps to Reproduce

Option I, quick

1. Establish the sync chain between two computers without bookmarks.
2. Wait 5 minutes
3. Open inspector for Brave Sync extension brave://inspect/#extensions, Sources tab, click Pretty print button
   
4. Find if (this.shouldListObject(startAt, category) || opts.compaction) { if (this.shouldListObject(startAt line and set the breakpoint on there
5. Wait for the breakpoint gets hit
6. Press F10 to make a step

Actual result:

6. code executes if block const s3ObjectsPromise = s3Helper.listObjects(this.s3, options, !!maxRecords);
   

Expected result:

6. Code should not go into `if` block

Option II, needs > 24h to see

1. Establish the sync chain between two computers having some bookmarks.
2. Wait more than 24h
3. Go to step 3 of Option I.
   ..................
   6 Code should go into if block, as we want to fetch from S3

Reproduces how often:

Easily

Brave version (brave://version info)

Brave	1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision	4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS	Linux

Version/Channel Information:

On any channel.

[bsclifton]

Closing as wontfix - will be solved with Sync v2