Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting BAT automatically selects ETH #7418

Closed
srirambv opened this issue Dec 16, 2019 · 3 comments
Closed

Selecting BAT automatically selects ETH #7418

srirambv opened this issue Dec 16, 2019 · 3 comments

Comments

@srirambv
Copy link
Contributor

Description

Selecting BAT automatically selects ETH

Steps to Reproduce

  1. Install component 0.1.32
  2. Create a new profile
  3. Select BAT from token list automatically selects ETH as well
  4. Selecting ETH doesn't highlight the entry

Actual result:

image

Expected result:

Should highlight the correct token

Reproduces how often:

Easy

Brave version (brave://version info)

Component 0.1.32

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@kjozwiak
Copy link
Member

You'll also run into this issue when creating a new wallet. Both ETH & BAT are selected right away without any interaction when initially creating a new wallet.

Also happens when restoring a wallet using either a CW or MM seed.

@bbondy bbondy added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Dec 20, 2019
@ryanml
Copy link
Contributor

ryanml commented Jan 6, 2020

Fixed via: brave/ethereum-remote-client#100

@ryanml ryanml closed this as completed Jan 6, 2020
@srirambv
Copy link
Contributor Author

srirambv commented Jan 9, 2020

Verification passed on

Brave 1.4.55 Chromium: 79.0.3945.117 (Official Build) dev (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Linux
Component 0.1.35
  • Verified selecting BAT only selects it
    image
  • Verified selecting ETH only selects it
    image

Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.35
  • Verified selecting BAT only selects it
    image
  • Verified selecting ETH only selects it
    image

Verification passed on

Brave 1.5.18 Chromium: 79.0.3945.117 (Official Build) nightly (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.35
  • Verified selecting BAT only selects it

Screen Shot 2020-01-09 at 12 43 21 PM

- Verified selecting ETH only selects it

Screen Shot 2020-01-09 at 12 43 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants