Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserved BAT text isn't displayed in Rewards summary section #7635

Closed
GeetaSarvadnya opened this issue Jan 7, 2020 · 10 comments
Closed

Reserved BAT text isn't displayed in Rewards summary section #7635

GeetaSarvadnya opened this issue Jan 7, 2020 · 10 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 7, 2020

Description

Reserved BAT text isn't displayed in Rewards summary section

Steps to Reproduce

  1. Clean profile staging env
  2. Claim UGP grants
  3. Send a one-time tip to an unverified pub https://google.com
  4. Open BR panel for google.com, reserved BAT text is displayed in panel summary
  5. 1 BAT reserved bat text isn't displayed in rewards summary section

Actual result:

Reserved BAT text display

BR panel:
image

Brave://rewards summary
image

Expected result:

Reserved BAT text should be displayed in Rewards summary section

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

@GeetaSarvadnya GeetaSarvadnya changed the title Reserved BAT text isn't displayed in Rewards summary section for unverified pubs Reserved BAT text isn't displayed in Rewards summary section Jan 7, 2020
@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya is this solved with a reload?

@GeetaSarvadnya
Copy link
Author

@NejcZdovc Reload and browser restart didn't solve the issue.

@masparrow
Copy link

@GeetaSarvadnya

Cannot reproduce with MacOSX or Windows 10, as of;

Version 1.5.21 Chromium: 79.0.3945.117 (Developer Build) (64-bit)

Can you please verify - and if reproducible can you confirm the platform(s) it reproduces on? Thanks!

@LaurenWags
Copy link
Member

Could not reproduce on macOS using

Brave 1.3.90 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)

Could you try again as per @masparrow request above?

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jan 22, 2020

@masparrow Issue is consistently reproducible in Windows 10 x64 - Bravebeta version 1.3.97. Reload/ close or open rewards summary did not display reserved BAT text in the summary section. Do let me know if you need more details. Thanks!

The issue isn't reproducible in the Nightly version 1.5.46 and Dev version 1.4.65

@GeetaSarvadnya
Copy link
Author

@btlechowski Can you please check this issue on Linux if it's not reproducible, can you please add the label as windows only?

@btlechowski
Copy link

Not reproducible on Ubuntu

Brave 1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS

image

@btlechowski
Copy link

Not reproducible on 1.5.57 on Windows 7 x64 and Windows 10 x64

image
image

Brave 1.5.57 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.5.57 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1909

We should retest when brave/brave-core#4372 and brave/brave-core#4399 are uplifted.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 5, 2020

@GeetaSarvadnya
Copy link
Author

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment