Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many scripts bypass shield #7725

Closed
cortopy opened this issue Jan 14, 2020 · 4 comments
Closed

Many scripts bypass shield #7725

cortopy opened this issue Jan 14, 2020 · 4 comments
Labels
closed/works-for-me feature/shields/adblock Blocking ads & trackers with Shields priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@cortopy
Copy link

cortopy commented Jan 14, 2020

Description

Brave is not blocking ads and scripts on 9to5mac.com

Steps to Reproduce

  1. Go to https://9to5mac.com/

Actual result:

as per this screenshot, not a single script is blocked:

image

Whereas using uBlock Origin 1.24.2 catches and blocks 14 scripts in chrome!!

image

Expected result:

Brave shield should block the same amount of scripts as uBlock Origin and not display any ads

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.2.42 Chromium: 79.0.3945.117 (Official Build) (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Linux

Version/Channel Information:

Also reproduced on Android

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Does the issue resolve itself when disabling Brave Rewards?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No

Miscellaneous Information:

@ryanbr
Copy link

ryanbr commented Jan 14, 2020

Aware of this, #7400

@ryanbr ryanbr closed this as completed Jan 14, 2020
@ryanbr ryanbr reopened this Jan 14, 2020
@ryanbr
Copy link

ryanbr commented Jan 14, 2020

9to5 and other related sites, are trying to get around this. even Ubo is having issues (tested this last night).

@rebron rebron added feature/shields/adblock Blocking ads & trackers with Shields priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 6, 2020
@rebron
Copy link
Collaborator

rebron commented Mar 6, 2020

@ryanbr not a dupe of #7400?

@liamengland1
Copy link

This can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/works-for-me feature/shields/adblock Blocking ads & trackers with Shields priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

5 participants