Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Not fixed) Video ads on YouTube have no Skip button #7735

Closed
Ladrason opened this issue Jan 15, 2020 · 4 comments
Closed

(Not fixed) Video ads on YouTube have no Skip button #7735

Ladrason opened this issue Jan 15, 2020 · 4 comments
Labels
closed/duplicate Issue has already been reported

Comments

@Ladrason
Copy link

Description

Adds on Youtube has no "skip ad" button.

This is causes by something Brave Shield does even though it's turned off. I know this because in the previous Nightly build when Shield seems to have been removed the ads worked perfectly fine.

Steps to Reproduce

  1. Turn off Brave Shields
  2. Start a Youtube video

Actual result:

The "skip ad" button is not present (https://i.imgur.com/kGqLkzR.jpg)

Expected result:

The "skip ad" button is present (https://i.imgur.com/Hoflu18.jpg)

Reproduces how often:

All the time

Brave version (brave://version info)

Brave 1.5.35 Chromium: 79.0.3945.117 (Official Build) nightly (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1909 (Build 18363.535)

Version/Channel Information:

This happens on all versions of Brave

Other Additional Information:

As I mentioned above this issue is related to Brave Shields. When it was "removed" yesterday (2020-01-14) the "Skip ad" button worked perfectly fine but now when it was added again the button "breaks"

Miscellaneous Information:

This is the same issue as what was reported in #2763 (comment) and it says there that the issue should have been fixed but I have not noticed anything changing.

@scrapyardrobot
Copy link

Confirmed,
Please @brave-dev ,I beg you
fix the thing,PLEASE
have a nice day

@anselmobattisti
Copy link

I'm with the same problem!

@rebron
Copy link
Collaborator

rebron commented Mar 6, 2020

Closing duplicate of #8209

@rebron rebron closed this as completed Mar 6, 2020
@rebron
Copy link
Collaborator

rebron commented Mar 6, 2020

This should be fixed with this pr brave/brave-core#4603

@rebron rebron added the closed/duplicate Issue has already been reported label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

4 participants