Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove sites from cookies 'allow' list if they're configured for shields down #7812

Open
marc1uk opened this issue Jan 18, 2020 · 1 comment
Labels
feature/cookies feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@marc1uk
Copy link

marc1uk commented Jan 18, 2020

Did check the existing tickets, couldn't find a similar issue.

Description

On brave://settings/content/cookies, attempting to remove some sides from the 'allow' list is not always possible. Many sites, with the setting 'All cookies, on this site only' are shown - and alongside each a little trash icon. However, the trash icon doesn't work if I've been to the site and clicked SHIELDS DOWN. For those entries, nothing happens, the item isn't removed, no error shows, it just does nothing.

Steps to Reproduce

  1. Visit a site with cookies
  2. Click shields down
  3. Go to brave://settings/content/cookies
  4. Click the trash icon next to the site you put shields down on (under Allowed)

Actual result:

Site should be removed.

Expected result:

Nothing happens.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave | 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | Linux

Version/Channel Information:

Haven't tried

Other Additional Information:

[EDIT]: Found this seems to be the behaviour for sites where 'shields down' is enabled. Navigating to the site and re-enabling shields does indeed remove the site from the 'allow' list, but this isn't especially intuitive. Perhaps a tip above the setting would be sufficient.

@marc1uk marc1uk changed the title Can't remove whitelisted sites from cookies list Can't remove sites from cookies 'allow' list if they're configured for shields down Jan 18, 2020
@rebron rebron added feature/shields The overall Shields feature in Brave. feature/cookies priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Mar 6, 2020
@bsclifton bsclifton removed their assignment Mar 6, 2020
@bsclifton
Copy link
Member

Updated to make steps a little more clear- thanks for the report, @marc1uk 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/cookies feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

3 participants