After excluding a site from A-C table Show All link is not shown in ac table

[GeetaSarvadnya]

Description

After excluding a site from A-C table Show All link is not shown

Steps to Reproduce

1. Clean profile 1.3.97
2. Enable rewards
3. Add a site to a-c table
4. Exclude the added site by clicking on Trash icon
5. After excluding a site from A-C table Show All link is not shown

Actual result:

After excluding a site from A-C table Show All link is not shown in ac table

Expected result:

After excluding a site from A-C table Show All link should be shown in a-c table

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? No
• Can you reproduce this issue with the nightly channel? No

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

[btlechowski]

Not reproducible on Ubuntu. Maybe a timing problem?

Brave	1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Ubuntu 18.04 LTS

[kjozwiak]

Seems like this specific to Windows. I couldn't reproduce the issue using macOS 10.15.2 x64 but easily reproduced with Win 10 x64 using the STR @GeetaSarvadnya provided.

Couldn't reproduce on macOS 10.15.2 x64:

Brave	1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.15.2 (Build 19C57)

Reproduced on Win 10 x64:

Brave	1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1909 (Build 18363.592)

[kjozwiak]

@rebron @NejcZdovc this is a regression we might want to consider fixing this on 1.3.x as it affects the most popular platform.

[btlechowski]

This issue is not reproducible on 1.5.57 on Windows 7 x64 and Windows 10 x64

Brave	1.5.57 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Brave	1.5.57 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1909

We should retest when brave/brave-core#4372 and brave/brave-core#4399 are uplifted.

[kjozwiak]

Believe we should be able to QA this now that brave/brave-core#4372 and brave/brave-core#4399 have been uplifted into 1.3.x via:

• Adds delays for suggestion api (uplift to 1.3) brave-core#4448
• Fixes json parse from the reconcile payload (uplift to 1.3) brave-core#4438

[GeetaSarvadnya]

Verification passed on

Brave	1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision	cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified SR from the description
• The issue is still not fixed logged a follow-up issue Follow up of #7840 - After excluding a site from A-C table Show All link is not shown in ac table #8071