Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate mojo types for Ads service #7856

Closed
yrliou opened this issue Jan 21, 2020 · 2 comments · Fixed by brave/brave-core#4224
Closed

Migrate mojo types for Ads service #7856

yrliou opened this issue Jan 21, 2020 · 2 comments · Fixed by brave/brave-core#4224

Comments

@yrliou
Copy link
Member

yrliou commented Jan 21, 2020

This is a part of the migration #7056, please see the meta issue for more details.

@yrliou
Copy link
Member Author

yrliou commented Jan 30, 2020

Test plan is specified in the PR.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 9, 2020

Verification passed on

Brave 1.5.109 Chromium: 80.0.3987.132 (Official Build) beta (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan from Ads mojo migration brave-core#4224
  • Verified that view, click, dismiss and landed confirmation types are recorded in confirmation.json file
  • Verified that Token Refill message is shown as expected
[17224:18400:0309/194700.774:INFO:refill_tokens.cc(50)] Refill
[17224:18400:0309/194700.774:INFO:refill_tokens.cc(75)] RequestSignedTokens
[17224:18400:0309/194700.774:INFO:refill_tokens.cc(84)] POST /v1/confirmation/token/{payment_id}
[17224:18400:0309/194700.774:INFO:refill_tokens.cc(342)] Generated 50 tokens
[17224:18400:0309/194700.777:INFO:refill_tokens.cc(345)] Blinded 50 tokens

[17224:18400:0309/194701.564:INFO:refill_tokens.cc(300)] Added 50 unblinded tokens, you now have 50 unblinded tokens
  • Verified that tokens are redeemed for viewed ads
[17224:18400:0309/194910.288:INFO:redeem_token.cc(407)] Added 1 unblinded payment token with an estimated redemption value of 0.05 BAT, you now have 1 unblinded payment tokens

Verification passed on

Brave 1.5.109 Chromium: 80.0.3987.132 (Official Build) beta (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS
  • Verified the test plan from Ads mojo migration brave-core#4224
    image
  • Verified that view, click, dismiss and landed confirmation types are recorded in confirmation.json file
  • Verified that Token Refill message is shown as expected
[15570:15570:0310/001221.173253:INFO:refill_tokens.cc(50)] Refill
[15570:15570:0310/001221.173268:INFO:refill_tokens.cc(75)] RequestSignedTokens
[15570:15570:0310/001221.173278:INFO:refill_tokens.cc(84)] POST /v1/confirmation/token/{payment_id}
[15570:15570:0310/001221.173777:INFO:refill_tokens.cc(342)] Generated 50 tokens
[15570:15570:0310/001221.208443:INFO:refill_tokens.cc(345)] Blinded 50 tokens
  • Verified that tokens are redeemed for viewed ads
[15570:15570:0310/001302.956076:INFO:redeem_token.cc(407)] Added 1 unblinded payment token with an estimated redemption value of 0.05 BAT, you now have 1 unblinded payment tokens

Verification passed with

Brave 1.5.109 Chromium: 80.0.3987.132 (Official Build) beta (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified the test plan from Ads mojo migration brave-core#4224
  • Verified that view, click, dismiss and landed confirmation types are recorded in confirmation.json file
  • Verified that Token Refill message is shown as expected
[4720:775:0312/173056.542756:INFO:refill_tokens.cc(50)] Refill
[4720:775:0312/173056.542770:INFO:refill_tokens.cc(75)] RequestSignedTokens
[4720:775:0312/173056.542780:INFO:refill_tokens.cc(84)] POST /v1/confirmation/token/{payment_id}
[4720:775:0312/173056.544238:INFO:refill_tokens.cc(342)] Generated 50 tokens
[4720:775:0312/173056.549015:INFO:refill_tokens.cc(345)] Blinded 50 tokens
[4720:775:0312/173111.984464:INFO:refill_tokens.cc(300)] Added 50 unblinded tokens, you now have 50 unblinded tokens
[5109:775:0313/183409.927405:INFO:refill_tokens.cc(62)] Retry getting signed tokens
[5109:775:0313/183409.927431:INFO:refill_tokens.cc(162)] GetSignedTokens
[5109:775:0313/183409.927451:INFO:refill_tokens.cc(164)] GET /v1/confirmation/token/{payment_id}?nonce={nonce}
[5109:775:0313/183409.927472:INFO:refill_tokens.cc(167)] URL Request:
[5109:775:0313/183409.927497:INFO:refill_tokens.cc(170)]   URL: https://ads-serve.brave.com/v1/confirmation/token/4a923c2d-2042-42e1-97cc-ca406e377303?nonce=9f2ea47b-150b-4875-b50a-782c659bffe1
[5109:775:0313/183410.035513:INFO:refill_tokens.cc(185)] OnGetSignedTokens
[5109:775:0313/183410.035568:INFO:refill_tokens.cc(187)] URL Request Response:
[5109:775:0313/183410.035584:INFO:refill_tokens.cc(188)]   URL: https://ads-serve.brave.com/v1/confirmation/token/4a923c2d-2042-42e1-97cc-ca406e377303?nonce=9f2ea47b-150b-4875-b50a-782c659bffe1
[5109:775:0313/183410.035599:INFO:refill_tokens.cc(189)]   Response Status Code: 200
[5109:775:0313/183410.043821:INFO:refill_tokens.cc(300)] Added 31 unblinded tokens, you now have 50 unblinded tokens
  • Verified that tokens are redeemed for viewed ads
[5010:775:0313/180234.379498:INFO:payout_tokens.cc(38)] Payout
[5010:775:0313/180234.379525:INFO:payout_tokens.cc(48)] RedeemPaymentTokens
[5010:775:0313/180234.379596:INFO:payout_tokens.cc(56)] PUT /v1/confirmation/payment/{payment_id}
[5010:775:0313/180234.945908:INFO:payout_tokens.cc(122)] Successfully paid out tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment