Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxies to handle Crowd Deny download #7976

Closed
jumde opened this issue Jan 29, 2020 · 1 comment · Fixed by brave/brave-core#4482
Closed

Add proxies to handle Crowd Deny download #7976

jumde opened this issue Jan 29, 2020 · 1 comment · Fixed by brave/brave-core#4482
Assignees
@jumde
Labels
privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.3.x - Release

Comments

@jumde
Copy link
Contributor

jumde commented Jan 29, 2020 •
edited
Loading

https://cs.chromium.org/chromium/src/chrome/browser/component_updater/crowd_deny_component_installer.cc

Test Plan

Specified here: brave/brave-core#4482
@jumde jumde mentioned this issue Jan 29, 2020
Closed
@jumde jumde added the privacy label Jan 30, 2020
@jumde jumde mentioned this issue Feb 3, 2020
Merged
32 tasks
@jumde jumde changed the title Investigate and re-enable Crowd Deny Add proxies to handle Crowd Deny download Feb 4, 2020
@jumde jumde self-assigned this Feb 4, 2020
@rebron rebron added this to the 1.3.x - Release milestone Feb 5, 2020
@rebron rebron modified the milestones: 1.3.x - Release, 1.6.x - Nightly Feb 6, 2020
@kjozwiak kjozwiak modified the milestones: 1.6.x - Nightly, 1.3.x - Release Feb 7, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2020 •
edited by GeetaSarvadnya
Loading

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.3 (Build 19D76)

Waited ~10min and ensured there was no connections to dl.google.com or *.gvt1.com.

Screen Shot 2020-02-07 at 12 32 05 PM

Screen Shot 2020-02-07 at 12 29 43 PM

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.14.6 (Build 18G103)

Screen Shot 2020-02-07 at 1 10 47 PM

Screen Shot 2020-02-07 at 1 11 50 PM

Verification passed on

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4482

image
image

Verification passed on

Brave 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumde jumde

Labels
privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Fix 7976: Adding a proxy for Crowd Deny brave/brave-core
6 participants
@jumde @kjozwiak @rebron @LaurenWags @btlechowski @GeetaSarvadnya