Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving of bookmark may not be synced when bookmark is added during Looking for device state #7991

Closed
btlechowski opened this issue Jan 31, 2020 · 2 comments

Comments

@btlechowski
Copy link

Found while testing: brave/brave-core#4324

If bookmarks were added during Looking for device state, then moving of existing bookmark will not be propagated. Note: best to follow the STR

Important: Reproducible on 1.5.x, 1.4.x, 1.3.x. Not reproducible on 1.2.x

Steps to Reproduce

  1. Clean profile DeviceA and DeviceB
  2. DeviceA: create bookmark a1.com
  3. DeviceA: create sync chain and copy code words
  4. DeviceB: enter code words
  5. DeviceB: [During Looking for device]create bookmark b1.com
  6. Wait for sync
  7. DeviceA: move a1.com after b1.com bookmark
  8. Wait till the change is propagated to DeviceB

DeviceA: Ubuntu 18.04LTS
DeviceB: Windows 7x64

Actual result:

The moving of bookmark is not propagate to another device
DeviceA
image

DeviceB
image

Expected result:

The moving of the bookmark is always propagated

Reproduces how often:

100% repro rate with above STR

Brave version (brave://version info)

Reproducible on

Brave 1.5.69 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.5.69 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS
Brave 1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS
Brave 1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Not Reproducible on

Brave 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS
Brave 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @jsecretan @AlexeyBarabash @darkdh @rebron @bsclifton

@darkdh
Copy link
Member

darkdh commented Feb 1, 2020

This might be dupe of #7691

@btlechowski
Copy link
Author

@darkdh Looks like it. Feel free to close one as a duplicate.

@darkdh darkdh added the closed/duplicate Issue has already been reported label Feb 3, 2020
@darkdh darkdh closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants