Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our frame color isn't applied on Windows #808

Closed
simonhong opened this issue Aug 22, 2018 · 1 comment · Fixed by brave/brave-core#351
Closed

Our frame color isn't applied on Windows #808

simonhong opened this issue Aug 22, 2018 · 1 comment · Fixed by brave/brave-core#351
Assignees
@simonhong
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@simonhong
Copy link
Member

DWM color is used instead.
Our frame color should be used always.

image
@simonhong simonhong self-assigned this Aug 22, 2018
@simonhong simonhong mentioned this issue Aug 22, 2018
Merged
11 tasks
@bbondy bbondy added this to the Releasable builds 0.55.x milestone Aug 30, 2018
@srirambv
Copy link
Contributor

srirambv commented Sep 20, 2018 •
edited by LaurenWags
Loading

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7
Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Brave theme brave/brave-core
5 participants
@bbondy @simonhong @srirambv @LaurenWags @btlechowski