Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Brave Ads in preparation for merging Publisher Ads #8294

Closed
tmancey opened this issue Feb 18, 2020 · 1 comment · Fixed by brave/brave-core#4685
Closed

Refactor Brave Ads in preparation for merging Publisher Ads #8294

tmancey opened this issue Feb 18, 2020 · 1 comment · Fixed by brave/brave-core#4685
Assignees
@tmancey
Labels
dev-concern feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.7.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 18, 2020

No description provided.

@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No feature/ads labels Feb 18, 2020
@tmancey tmancey self-assigned this Feb 18, 2020
@tmancey tmancey mentioned this issue Feb 18, 2020
Closed
16 tasks
@tmancey tmancey mentioned this issue Feb 19, 2020
Merged
32 tasks
@tmancey tmancey added QA/Yes and removed QA/No labels Feb 19, 2020
@tmancey tmancey added this to the 1.7.x - Nightly milestone Feb 20, 2020
This was referenced Feb 21, 2020
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Mar 30, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-03-30 at 3 45 38 PM

Screen Shot 2020-03-30 at 3 45 45 PM

Screen Shot 2020-03-30 at 3 45 20 PM

Verification passed on

Brave 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Verified on staging
image

Verified on production
image

Verification passed on

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

image

This was referenced Apr 2, 2020
Closed
Closed
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.7.x - Release
Development

Successfully merging a pull request may close this issue.

Refactor Brave Ads in preparation for merging Publisher Ads brave/brave-core
5 participants
@tmancey @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya