Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to disable APIs that intentionally identify the browser as Brave #8757

Open
pes10k opened this issue Mar 19, 2020 · 12 comments
Open
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature-request priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@pes10k
Copy link
Contributor

pes10k commented Mar 19, 2020

Currently brave allows sites to determine if its brave by querying a Brave-specific API (navigator.brave.*). This was done in #8216 to:

  1. make easy whats already possible for sites (by looking for Brave unique modifications), and
  2. make explicit that keeping brave indistinguishable from chrome is not part of brave's privacy threat model

However, it would be nice to have a way for users to disable this if needed, either per site in shields, or globally through a flag.

@pes10k pes10k added feature-request feature/shields/panel Front-end design and functionality of the Shields panel. labels Mar 19, 2020
@Johann999
Copy link

The whole thing is paradoxical, unclear and contradictory.
On the one hand, Brave does not appear in the user agent, supposedly because of fingerprinting.
On the other hand, Brave can query using the DuckDuckGo API and more recently using navigator.brave.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 20, 2020
@pes10k
Copy link
Contributor Author

pes10k commented Mar 20, 2020

On the one hand, Brave does not appear in the user agent, supposedly because of fingerprinting.

This is not correct. Brave doesn't appear in the UA for web compat reasons. Brave makes many changes in the browser that it already looks / behaves very different from chromium, so reporting brave in the UA would not have any change in the browser's fingerprintability (e.g. the other changes brave makes are consistent across all brave instances per platform, so changing the UA in a way that was also consistent across all brave instances per platform would not affect the anonymity sets at all).

@arpitjindal97
Copy link

You should have implement previous backlog by giving an option to change it. The whole purpose of using Brave seems worthless now. Some websites have started blocking Brave intentionally.

@dlecan
Copy link

dlecan commented Jul 27, 2021

Some websites have started blocking Brave intentionally.

Which ones?

@arpitjindal97
Copy link

KodeKloud Labs
KodeKloud

@pes10k
Copy link
Contributor Author

pes10k commented Jul 27, 2021

@ryanbr can you add a fix for the above, with another remove isBrave for the above?

@ryanbr
Copy link

ryanbr commented Jul 28, 2021

KodeKloud Labs

Does this error message come from kodekloud.com domain? @arpitjindal97

@arpitjindal97
Copy link

When you try open Labs session on kodekloud.com then you will see this error

@ryanbr
Copy link

ryanbr commented Jul 28, 2021

If you add kodekloud.com##+js(aopw, navigator.brave) into brave://adblock, clear the cookies and relogin.

Does that help? @arpitjindal97

@ryanbr
Copy link

ryanbr commented Jul 28, 2021

Apologies for the delay, managed to recreate the issue, @arpitjindal97 give it 24-48hrs the update will fix this issue with shields up.

@arpitjindal97
Copy link

Thanks @ryanbr , new update fixed the kodekloud issue. Waiting for a full fledged solution.

@ryanbr
Copy link

ryanbr commented Jul 30, 2021

Yeah, tried reaching out to them via twitter, got no response @arpitjindal97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature-request priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

6 participants