Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single task runner for HTTPSEverywhereService #896

Closed
bbondy opened this issue Aug 31, 2018 · 0 comments · Fixed by brave/brave-core#378
Closed

Use a single task runner for HTTPSEverywhereService #896

bbondy opened this issue Aug 31, 2018 · 0 comments · Fixed by brave/brave-core#378
Assignees
Labels

Comments

@bbondy
Copy link
Member

bbondy commented Aug 31, 2018

It might be unsafe to use a scoped ref to a task runner which goes out of scope.
It also is a problem that multiple task runners and hence threads can try to get https information.

We should also use a sequence checker to make sure the DB work is done on the same thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant