Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of band user model updates for Brave Ads #9147

Closed
tmancey opened this issue Apr 11, 2020 · 1 comment · Fixed by brave/brave-core#5209
Closed

Out of band user model updates for Brave Ads #9147

tmancey opened this issue Apr 11, 2020 · 1 comment · Fixed by brave/brave-core#5209
Assignees
@tmancey @moritzhaller
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.13.x - Release #1

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 11, 2020 •
edited
Loading

This ticket includes:

  1. the new BraveUserModelInstaller component to download any kind of ads related model files
  2. integrating the update mechanism in 1. with the purchase intent and page classifiers to allow "out-of-band" updates

Related PRs:
@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. feature/ads labels Apr 11, 2020
@tmancey tmancey modified the milestone: 1.9.x - Nightly Apr 21, 2020
This was referenced May 3, 2020
Closed
Closed
Closed
@tmancey tmancey changed the title Out of band metadata updates for page classification user models and purchase intent Out of band metadata updates for Brave Ads purchase intent May 4, 2020
@moritzhaller moritzhaller mentioned this issue May 15, 2020
Merged
32 tasks
@tmancey tmancey changed the title Out of band metadata updates for Brave Ads purchase intent Out of band metadata updates for Brave Ads purchase intent user models May 29, 2020
@tmancey tmancey mentioned this issue May 31, 2020
Closed
@tmancey tmancey mentioned this issue Jul 2, 2020
Closed
@tmancey tmancey mentioned this issue Jul 7, 2020
Closed
@tmancey tmancey added this to the 1.13.x - Nightly milestone Jul 10, 2020
@tmancey tmancey added closed/duplicate Issue has already been reported QA/No and removed QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include labels Jul 10, 2020
@tmancey tmancey changed the title Out of band metadata updates for Brave Ads purchase intent user models Out of band metadata updates for Brave Ads user models Jul 10, 2020
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include and removed QA/No closed/duplicate Issue has already been reported labels Jul 10, 2020
@tmancey tmancey changed the title Out of band metadata updates for Brave Ads user models Out of band user model updates for Brave Ads Jul 10, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Aug 18, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave | 1.13.76 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#5209

Plan 1 from https://github.com/brave/brave-core/pull/5209 using `--use-dev-goupdater-url`
  • Confirmed component version installed prior to running component update job:
macOS-en-preupdate macOS-US-preupdate
  • Confirmed component version updated after running component update job:
macOS-en-postupdate macOS-US-postupdate

Note - US has two components since page classifier uses language and purchase intent uses country.

Disabled Ads, re-enabled and saw the below in the terminal:

[16936:775:0818/125007.686274:VERBOSE1:ads_service_impl.cc(551)] Shutting down ads
[16936:775:0818/125007.686687:VERBOSE3:ad_notifications.cc(306)] Saving ad notifications state
[16936:775:0818/125007.686906:VERBOSE1:ads_service_impl.cc(572)] Successfully shutdown ads
[16936:775:0818/125034.507397:VERBOSE1:user_model_file_service.cc(103)] Registering Brave User Model Installer (US) with id kkjipiepeooghlclkedllogndmohhnhi
[16936:775:0818/125034.507484:VERBOSE1:user_model_file_service.cc(122)] Registering Brave User Model Installer (en) with id emgmepnebbddgnkhfmhdhmjifkglkamo
[16936:775:0818/125034.508751:VERBOSE1:user_model_file_service.cc(207)] Updating kkjipiepeooghlclkedllogndmohhnhi user model
[16936:775:0818/125034.508786:VERBOSE1:user_model_file_service.cc(214)] Notifying user model observers
[16936:775:0818/125034.508945:VERBOSE1:user_model_file_service.cc(207)] Updating emgmepnebbddgnkhfmhdhmjifkglkamo user model
[16936:775:0818/125034.508970:VERBOSE1:user_model_file_service.cc(214)] Notifying user model observers
[16936:775:0818/125034.575306:VERBOSE1:ads_service_impl.cc(2025)] Loading user model from /Users/lauren/Library/Application Support/BraveSoftware/Brave-Browser-Dev/kkjipiepeooghlclkedllogndmohhnhi/1.0.5/kkjipiepeooghlclkedllogndmohhnhi
[16936:775:0818/125034.575408:VERBOSE1:ads_service_impl.cc(2025)] Loading user model from /Users/lauren/Library/Application Support/BraveSoftware/Brave-Browser-Dev/emgmepnebbddgnkhfmhdhmjifkglkamo/1.0.5/emgmepnebbddgnkhfmhdhmjifkglkamo
[16936:775:0818/125034.575472:VERBOSE1:ads_impl.cc(138)] Initializing ads
[16936:775:0818/125034.575858:VERBOSE1:ads_impl.cc(689)] Successfully loaded kkjipiepeooghlclkedllogndmohhnhi purchase intent user model
[16936:775:0818/125034.576031:VERBOSE1:ads_impl.cc(696)] Successfully initialized kkjipiepeooghlclkedllogndmohhnhi purchase intent user model
[16936:775:0818/125034.614914:VERBOSE1:ads_impl.cc(658)] Successfully loaded emgmepnebbddgnkhfmhdhmjifkglkamo page classification user model
[16936:775:0818/125034.889687:VERBOSE1:ads_impl.cc(666)] Successfully initialized emgmepnebbddgnkhfmhdhmjifkglkamo page classification user model

Confirmed able to view ad after toggling ads off and back on:

[16936:775:0818/125638.210594:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 4
[16936:775:0818/125638.210673:VERBOSE3:eligible_ads_priority_filter.cc(89)] 2 ads with a lower priority of 6
[16936:775:0818/125638.210718:VERBOSE1:ads_impl.cc(1014)] Found 1 eligible ads
Plan 2 from https://github.com/brave/brave-core/pull/5209 using staging ads env
  • Spot checked spreadsheet provided by Moritz for testing US segments on staging env. Checked 2 keywords and 1 site. Confirmed entries added in client.json.
  "purchaseIntentSignalHistory": {
    "Alpha Influencers": [
      {
        "timestamp_in_seconds": 1597772023,
        "weight": 1
      }
    ],
    "Mainstream Enthusiasts": [
      {
        "timestamp_in_seconds": 1597772023,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1597772237,
        "weight": 1
      }
    ],
    "PC Purists": [
      {
        "timestamp_in_seconds": 1597772023,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1597772282,
        "weight": 1
      }
    ]
  },
  • Spot checked spreadsheet provided by Moritz for testing JA segments on staging env. Checked 2 keywords and 1 site. Confirmed entries added in client.json.
  "purchaseIntentSignalHistory": {
    "jp trial 2-owned website": [
      {
        "timestamp_in_seconds": 1597775894,
        "weight": 1
      }
    ],
    "jp trial 3-search competitor word": [
      {
        "timestamp_in_seconds": 1597775955,
        "weight": 1
      }
    ],
    "jp trial 4-search related word": [
      {
        "timestamp_in_seconds": 1597776018,
        "weight": 1
      }
    ]
  },
Plan 3 from https://github.com/brave/brave-core/pull/5209 using env as noted below
  • Checked a couple pages with US/en on staging. Confirmed en component on brave://components. Confirmed pages were classified:

brave.com:

[17401:775:0818/145725.473233:VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is technology & computing-software

espn.com:

[17401:775:0818/150034.580795:VERBOSE1:ads_impl.cc(805)] Classified page as sports-basketball. Winning page classification over time is technology & computing-software

instyle.com:

[17401:775:0818/150127.714125:VERBOSE1:ads_impl.cc(805)] Classified page as other-other. Winning page classification over time is technology & computing-software
  • Checked a couple pages with Germany/de on staging. Confirmed de component on brave://components. Confirmed pages were classified:

brave.com:

[17495:775:0818/150407.877614:VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is technology & computing-software

deutschland.de:

[17495:775:0818/150628.777786:VERBOSE1:ads_impl.cc(805)] Classified page as sports-olympics. Winning page classification over time is sports-olympics

aljazeera.com:

[17495:775:0818/150726.674654:VERBOSE1:ads_impl.cc(805)] Classified page as other-other. Winning page classification over time is sports-olympics
Upgrade check 1
  • Setup for US locale (this is a country which has page classification and purchase intent).
  • Installed 1.12.x for staging.
  • Enabled Rewards.
  • Closed browser.
  • Upgraded to 1.13.x
  • Confirmed expected components on brave://components
  • Confirmed still able to get ad notifications after upgrade to 1.13.x:
[18090:775:0818/160528.893671:VERBOSE1:ads_impl.cc(901)] No categories to serve targeted ads
[18090:775:0818/160528.893775:VERBOSE1:ads_impl.cc(976)] Serving ad notification from untargeted category
[18090:775:0818/160528.909095:VERBOSE2:eligible_ads_priority_filter.cc(81)] 23 eligible ads with a priority of 1
[18090:775:0818/160528.909165:VERBOSE1:ads_impl.cc(1014)] Found 23 eligible ads

[18090:775:0818/160528.912847:VERBOSE1:confirmations_impl.cc(1163)] Confirm ad:
  creativeInstanceId: 0ae3c486-13f2-4ec7-9376-5578d7b0dcd8
  creativeSetId: 32439113-32d2-4b50-9497-405b7eedd1d5
  category: untargeted
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view
  • Confirmed purchase intent entries added in client.json after upgrade:
  "purchaseIntentSignalHistory": {
    "Alpha Influencers": [
      {
        "timestamp_in_seconds": 1597781178,
        "weight": 1
      }
    ],
    "Mainstream Enthusiasts": [
      {
        "timestamp_in_seconds": 1597781178,
        "weight": 1
      }
    ],
    "PC Purists": [
      {
        "timestamp_in_seconds": 1597781178,
        "weight": 1
      }
    ]
  },
  • Confirmed page classification still occurs after upgrade

hotels.com:

[18090:775:0818/160807.560829:VERBOSE1:ads_impl.cc(805)] Classified page as travel-travel. Winning page classification over time is travel-travel
Upgrade check 2
  • Setup for Polish locale (this is a country which does not have a page classification model or purchase intent).
  • Installed 1.12.x for production.
  • Enabled Rewards.
  • Closed browser.
  • Upgraded to 1.13.x.
  • Confirmed still able to get ad notifications after upgrade to 1.13.x:
[17912:775:0818/153437.046532:VERBOSE1:ads_impl.cc(901)] No categories to serve targeted ads
[17912:775:0818/153437.046605:VERBOSE1:ads_impl.cc(976)] Serving ad notification from untargeted category
[17912:775:0818/153437.047559:VERBOSE2:eligible_ads_priority_filter.cc(81)] 2 eligible ads with a priority of 1
[17912:775:0818/153437.047631:VERBOSE1:ads_impl.cc(1014)] Found 2 eligible ads

[17912:775:0818/153437.049702:VERBOSE1:confirmations_impl.cc(1163)] Confirm ad:
  creativeInstanceId: bd658ffb-ed48-428f-8ad3-09bd5bf6feaf
  creativeSetId: 46fa3850-f600-4d3a-a46e-b8cb6653bcd8
  category: untargeted
  targetUrl: https://proton.go2cloud.org/aff_c?offer_id=15&aff_id=1397
  geoTarget: PL
  confirmationType: view

Verified passed with

Brave	1.13.76 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	Linux

Verified test plan from brave/brave-core#5209

Plan 1 from https://github.com/brave/brave-core/pull/5209 using `--use-dev-goupdater-url`
  • Confirmed component version installed prior to running component update job:
Linux-preupdate
  • Confirmed component version updated after running component update job:
Linux-postupdate

Note - US has two components since page classifier uses language and purchase intent uses country.

Disabled Ads, re-enabled and saw the below in the terminal:

[4346:4346:0818/094951.777676:VERBOSE1:ads_service_impl.cc(551)] Shutting down ads
[4346:4346:0818/094951.778442:VERBOSE3:ad_notifications.cc(306)] Saving ad notifications state
[4346:4346:0818/094951.778571:VERBOSE1:ads_service_impl.cc(572)] Successfully shutdown ads
[4346:4346:0818/095044.743268:VERBOSE1:uphold.cc(131)] Wallet data is empty
[4346:4346:0818/095144.733402:VERBOSE1:uphold.cc(131)] Wallet data is empty
[4346:4346:0818/095222.129408:VERBOSE1:ads_service_impl.cc(2025)] Loading user model from /home/lauren/.config/BraveSoftware/Brave-Browser-Dev/kkjipiepeooghlclkedllogndmohhnhi/1.0.5/kkjipiepeooghlclkedllogndmohhnhi
[4346:4346:0818/095222.129451:VERBOSE1:ads_service_impl.cc(2025)] Loading user model from /home/lauren/.config/BraveSoftware/Brave-Browser-Dev/emgmepnebbddgnkhfmhdhmjifkglkamo/1.0.5/emgmepnebbddgnkhfmhdhmjifkglkamo
[4346:4346:0818/095222.130804:VERBOSE1:ads_impl.cc(138)] Initializing ads
[4346:4346:0818/095222.130854:VERBOSE1:ads_impl.cc(689)] Successfully loaded kkjipiepeooghlclkedllogndmohhnhi purchase intent user model
[4346:4346:0818/095222.130870:VERBOSE1:ads_impl.cc(696)] Successfully initialized kkjipiepeooghlclkedllogndmohhnhi purchase intent user model
[4346:4346:0818/095222.231277:VERBOSE1:ads_impl.cc(658)] Successfully loaded emgmepnebbddgnkhfmhdhmjifkglkamo page classification user model
[4346:4346:0818/095222.655169:VERBOSE1:ads_impl.cc(666)] Successfully initialized emgmepnebbddgnkhfmhdhmjifkglkamo page classification user model

Confirmed able to view ad after toggling ads off and back on:

[4776:4776:0818/095828.329137:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 6
[4776:4776:0818/095828.330193:VERBOSE1:ads_impl.cc(1014)] Found 1 eligible ads
Plan 2 from https://github.com/brave/brave-core/pull/5209 using staging ads env
  • Spot checked spreadsheet provided by Moritz for testing US segments on staging env. Checked 2 keywords and 1 site. Confirmed entries added in client.json.
  "purchaseIntentSignalHistory": {
    "Alpha Influencers": [
      {
        "timestamp_in_seconds": 1597772481,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1597772540,
        "weight": 1
      }
    ],
    "Mainstream Enthusiasts": [
      {
        "timestamp_in_seconds": 1597772481,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1597772511,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1597772540,
        "weight": 1
      }
    ],
    "PC Purists": [
      {
        "timestamp_in_seconds": 1597772481,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1597772540,
        "weight": 1
      }
    ]
  },
  • Spot checked spreadsheet provided by Moritz for testing JA segments on staging env. Checked 2 keywords and 1 site. Confirmed entries added in client.json.
  "purchaseIntentSignalHistory": {
    "jp trial 1-search related word": [
      {
        "timestamp_in_seconds": 1597776745,
        "weight": 1
      }
    ],
    "jp trial 3-search competitor word": [
      {
        "timestamp_in_seconds": 1597776709,
        "weight": 1
      }
    ],
    "jp trial 4-owned website": [
      {
        "timestamp_in_seconds": 1597776634,
        "weight": 1
      }
    ]
  },
Plan 3 from https://github.com/brave/brave-core/pull/5209 using env as noted
  • Checked a couple pages with US/en on staging. Confirmed en component on brave://components. Confirmed pages were classified:

brave.com:

[2183:2183:0818/121655.958461:VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is technology & computing-software

huffingtonpost.com:

[2183:2183:0818/121724.383255:VERBOSE1:ads_impl.cc(805)] Classified page as other-other. Winning page classification over time is other-other

f1.com:

[2183:2183:0818/121818.666058:VERBOSE1:ads_impl.cc(805)] Classified page as sports-racing. Winning page classification over time is other-other
  • Checked a couple pages with France/Fr on staging. Confirmed fr component on brave://components. Confirmed pages were classified:

brave.com:

[2193:2193:0818/122212.395437:VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-personal finance. Winning page classification over time is personal finance-personal finance

instyle.com:

[2193:2193:0818/122314.719416:VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is personal finance-personal finance

france24.com:

[2193:2193:0818/122539.481356:VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-personal finance. Winning page classification over time is personal finance-personal finance
Upgrade check 1
  • Setup for US locale (this is a country which has page classification and purchase intent).
  • Installed 1.12.x for staging.
  • Enabled Rewards.
  • Closed browser.
  • Upgraded to 1.13.x
  • Confirmed expected components on brave://components
  • Confirmed still able to get ad notifications after upgrade to 1.13.x:
[4072:4072:0818/131724.311936:VERBOSE1:ads_impl.cc(901)] No categories to serve targeted ads
[4072:4072:0818/131724.312063:VERBOSE1:ads_impl.cc(976)] Serving ad notification from untargeted category
[4072:4072:0818/131724.322315:VERBOSE2:eligible_ads_priority_filter.cc(81)] 23 eligible ads with a priority of 1
[4072:4072:0818/131724.322418:VERBOSE1:ads_impl.cc(1014)] Found 23 eligible ads

[4072:4072:0818/131724.346942:VERBOSE1:confirmations_impl.cc(1163)] Confirm ad:
  creativeInstanceId: 022c8846-80da-4c76-b099-c84391fca85f
  creativeSetId: 32439113-32d2-4b50-9497-405b7eedd1d5
  category: untargeted
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view
  • Confirmed purchase intent entries added in client.json after upgrade:
  "purchaseIntentSignalHistory": {
    "Mainstream Enthusiasts": [
      {
        "timestamp_in_seconds": 1597781908,
        "weight": 1
      }
    ]
  },
  • Confirmed page classification still occurs after upgrade

hotels.com:

[4072:4072:0818/131938.015881:VERBOSE1:ads_impl.cc(805)] Classified page as travel-travel. Winning page classification over time is travel-travel

Verified PASSED on Win 10 x64 using the following build:

Brave | 1.13.76 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
--- | ---
Revision  | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS  | Windows 10 OS Version 2004 (Build 19041.450)

Verified test plan from brave/brave-core#5209

Plan 1 from https://github.com/brave/brave-core/pull/5209 using `--use-dev-goupdater-url`
  • Confirmed component version installed prior to running component update job:
Screen Shot 2020-08-20 at 1 33 14 AM Screen Shot 2020-08-20 at 1 33 24 AM
  • Confirmed component version updated after running component update job:
Screen Shot 2020-08-20 at 1 35 01 AM Screen Shot 2020-08-20 at 1 35 05 AM

Note - US has two components since page classifier uses language and purchase intent uses country.

Disabled Ads, re-enabled and saw the below in the terminal:

[9128:2236:0820/052516.337:VERBOSE1:ads_service_impl.cc(551)] Shutting down ads
[9128:2236:0820/052516.341:VERBOSE3:ad_notifications.cc(306)] Saving ad notifications state
[9128:2236:0820/052516.341:VERBOSE1:ads_service_impl.cc(572)] Successfully shutdown ads
[9128:2236:0820/052526.001:VERBOSE1:user_model_file_service.cc(103)] Registering Brave User Model Installer (US) with id kkjipiepeooghlclkedllogndmohhnhi
[9128:2236:0820/052526.002:VERBOSE1:user_model_file_service.cc(122)] Registering Brave User Model Installer (en) with id emgmepnebbddgnkhfmhdhmjifkglkamo
[9128:2236:0820/052526.014:VERBOSE1:user_model_file_service.cc(207)] Updating emgmepnebbddgnkhfmhdhmjifkglkamo user model
[9128:2236:0820/052526.015:VERBOSE1:user_model_file_service.cc(214)] Notifying user model observers
[9128:2236:0820/052526.020:VERBOSE1:user_model_file_service.cc(207)] Updating kkjipiepeooghlclkedllogndmohhnhi user model
[9128:2236:0820/052526.021:VERBOSE1:user_model_file_service.cc(214)] Notifying user model observers
[9128:2236:0820/052526.077:VERBOSE1:ads_service_impl.cc(2025)] Loading user model from C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser-Dev\User Data\emgmepnebbddgnkhfmhdhmjifkglkamo\1.0.5\emgmepnebbddgnkhfmhdhmjifkglkamo
[9128:2236:0820/052526.078:VERBOSE1:ads_service_impl.cc(2025)] Loading user model from C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser-Dev\User Data\kkjipiepeooghlclkedllogndmohhnhi\1.0.5\kkjipiepeooghlclkedllogndmohhnhi
[9128:2236:0820/052526.078:VERBOSE1:ads_impl.cc(138)] Initializing ads
[9128:2236:0820/052526.142:VERBOSE1:ads_impl.cc(658)] Successfully loaded emgmepnebbddgnkhfmhdhmjifkglkamo page classification user model
[9128:2236:0820/052526.602:VERBOSE1:ads_impl.cc(666)] Successfully initialized emgmepnebbddgnkhfmhdhmjifkglkamo page classification user model
[9128:2236:0820/052526.604:VERBOSE1:ads_impl.cc(689)] Successfully loaded kkjipiepeooghlclkedllogndmohhnhi purchase intent user model
[9128:2236:0820/052526.605:VERBOSE1:ads_impl.cc(696)] Successfully initialized kkjipiepeooghlclkedllogndmohhnhi purchase intent user model

Confirmed able to view ad after toggling ads off and back on:

[16936:775:0818/125638.210594:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 4
[16936:775:0818/125638.210673:VERBOSE3:eligible_ads_priority_filter.cc(89)] 2 ads with a lower priority of 6
[16936:775:0818/125638.210718:VERBOSE1:ads_impl.cc(1014)] Found 1 eligible ads
Plan 2 from https://github.com/brave/brave-core/pull/5209 using staging ads env
  • Spot checked spreadsheet provided by Moritz for testing US segments on staging env. Checked 2 keywords and 1 site. Confirmed entries added in client.json.
"purchaseIntentSignalHistory": {
    "Mainstream Enthusiasts": [
      {
        "timestamp_in_seconds": 1597916526,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1597916665,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1597916710,
        "weight": 1
      }
    ],
    "PC Purists": [
      {
        "timestamp_in_seconds": 1597916526,
        "weight": 1
      }
    ]
  }
  • Spot checked spreadsheet provided by Moritz for testing JA segments on staging env. Checked 2 keywords and 1 site. Confirmed entries added in client.json.
"purchaseIntentSignalHistory": {
    "jp trial 1-search competitor word": [
      {
        "timestamp_in_seconds": 1597917695,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1597917722,
        "weight": 1
      }
    ],
    "jp trial 2-owned website": [
      {
        "timestamp_in_seconds": 1597917664,
        "weight": 1
      }
    ]
  },
Plan 3 from https://github.com/brave/brave-core/pull/5209 using env as noted below
  • Checked a couple pages with US/en on staging. Confirmed en component on brave://components. Confirmed pages were classified:

brave.com

[15052:15056:0824/141858.823:VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is technology & computing-software

https://petlifetoday.com/best-pet-blogs/

[17072:15324:0824/143221.806:VERBOSE1:ads_impl.cc(805)] Classified page as pets-pets. Winning page classification over time is sports-sports

https://www.flipkart.com/

[8800:5408:0824/143518.124:VERBOSE1:ads_impl.cc(805)] Classified page as home-appliances. Winning page classification over time is home-appliances

aljazeera.com

[15592:5280:0824/144100.007:VERBOSE1:ads_impl.cc(805)] Classified page as other-other. Winning page classification over time is other-other

Checked a couple pages with Australia/AU on staging. Confirmed en component on brave://components. Confirmed pages were classified:

brave.com

[4160:14080:0824/163144.032:VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is technology & computing-software

https://www.flipkart.com/

[9812:13500:0824/165253.156:VERBOSE1:ads_impl.cc(805)] Classified page as home-appliances. Winning page classification over time is home-appliances

aljazeera.com

[9476:16820:0824/163622.283:VERBOSE1:ads_impl.cc(805)] Classified page as other-other. Winning page classification over time is other-other
Upgrade check 1
  • Setup for US locale (this is a country which has page classification and purchase intent).
  • Installed 1.12.x for staging.
  • Enabled Rewards.
  • Closed browser.
  • Upgraded to 1.13.x
  • Confirmed expected components on brave://components
  • Confirmed still able to get ad notifications after upgrade to 1.13.x:
14548:14764:0824/172156.400:VERBOSE1:ads_impl.cc(928)] No eligible ads found in categories:
[14548:14764:0824/172156.400:VERBOSE1:ads_impl.cc(930)]   travel-travel
[14548:14764:0824/172156.400:VERBOSE1:ads_impl.cc(930)]   travel-hotels
[14548:14764:0824/172156.400:VERBOSE1:ads_impl.cc(930)]   personal finance-insurance
[14548:14764:0824/172156.400:VERBOSE1:ads_impl.cc(961)] Serving ad from parent categories:
[14548:14764:0824/172156.400:VERBOSE1:ads_impl.cc(963)]   travel
[14548:14764:0824/172156.400:VERBOSE1:ads_impl.cc(963)]   personal finance
[14548:14764:0824/172156.415:VERBOSE2:eligible_ads_priority_filter.cc(81)] 24 eligible ads with a priority of 1
[14548:14764:0824/172156.415:VERBOSE1:ads_impl.cc(1014)] Found 24 eligible ads
[14548:14764:0824/172156.415:VERBOSE3:client.cc(525)] Saving client state
[14548:14764:0824/172156.415:VERBOSE3:client.cc(525)] Saving client state
[14548:14764:0824/172156.415:VERBOSE3:client.cc(525)] Saving client state
[14548:14764:0824/172156.415:VERBOSE3:client.cc(525)] Saving client state
[14548:14764:0824/172156.415:VERBOSE1:ads_impl.cc(1277)] Ad notification shown:
  uuid: b2389522-0490-4ab9-8d36-95b30cf8d223
  parentUuid: 532648ad-82bf-4c86-931e-f80a68d9bdf9
  creativeInstanceId: 850caa74-2cb6-4ea2-b0cf-11031cc157ce
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: personal finance
  title: Uphold - Brave Partner
  body: Buy and Sell Major Cryptos
  targetUrl: https://travala.com/

[14548:14764:0824/172156.416:VERBOSE1:confirmations_impl.cc(1163)] Confirm ad:
  creativeInstanceId: 850caa74-2cb6-4ea2-b0cf-11031cc157ce
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: personal finance
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view
  • Confirmed page classification still occurs after upgrade
[14548:14764:0824/172129.069:VERBOSE1:ads_impl.cc(805)] Classified page as travel-travel. Winning page classification over time is travel-travel
  • Confirmed purchase intent entries added in client.json after upgrade:

Keyword: Mobile Games

  "purchaseIntentSignalHistory": {
    "Mainstream Enthusiasts": [
      {
        "timestamp_in_seconds": 1598273695,
        "weight": 1
      }
    ]
  }

@kjozwiak kjozwiak mentioned this issue Aug 21, 2020
Closed
42 tasks
@LaurenWags LaurenWags mentioned this issue Aug 26, 2020
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

@moritzhaller moritzhaller

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

Implement out of band updates for Brave Ads brave/brave-core
4 participants
@tmancey @moritzhaller @LaurenWags @GeetaSarvadnya