Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification service #922

Closed
NejcZdovc opened this issue Sep 2, 2018 · 2 comments · Fixed by brave/brave-core#581
Closed

Notification service #922

NejcZdovc opened this issue Sep 2, 2018 · 2 comments · Fixed by brave/brave-core#581

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 2, 2018

When we receive new event that is worth showing to the user (list below) we need to send it to the url bar icon. We should create observable that url bar can use.

Related issue #921

Notifications:

  • auto contribute (when contribution is done)
  • token grant (when new grant is available)
  • error for failed contribution
  • 1 day before contribution
  • 3 days before if you don't have enough funds

@davidtemkin should we also show when recurring donation is done?

@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 2, 2018
@NejcZdovc NejcZdovc changed the title Add notification service Notification service Sep 2, 2018
@davidtemkin
Copy link

Auto contribute should occur on the same cycle as recurring donations - so the event is the same @NejcZdovc

We also need to notify when the scheduled contribution fails -- i.e., not enough funds to cover the total of auto-contribute monthly budget + total of all recurring donations

@NejcZdovc
Copy link
Contributor Author

@davidtemkin added to the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants