Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove custom tabs option for tablets #9220

Closed
srirambv opened this issue Apr 15, 2020 · 1 comment · Fixed by brave/brave-core#5253
Closed

[Android] Remove custom tabs option for tablets #9220

srirambv opened this issue Apr 15, 2020 · 1 comment · Fixed by brave/brave-core#5253
Labels
android-tablet-specific feature/global-settings Settings at browser level independent of shields settings OS/Android Fixes related to Android browser functionality QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
Android 1.7.x Rel...

Comments

@srirambv
Copy link
Contributor

Description

Remove custom tabs option for tablets since tablets doesn't support it

Steps to reproduce

  1. Install 1.9.21 nightly build
  2. Open settings
  3. Custom tabs option is shown under controls

Actual result

image

Expected result

No option for custom tabs setting as tablet doesn't support custom tabs

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? NA
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Tablet
  • Android version: 9.0

Brave version

1.9.21 Nighlty

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@srirambv srirambv added feature/global-settings Settings at browser level independent of shields settings QA/Yes OS/Android Fixes related to Android browser functionality android-tablet-specific labels Apr 15, 2020
@srirambv srirambv mentioned this issue Apr 15, 2020
Merged
32 tasks
@srirambv srirambv added this to the Android 1.7.x Release milestone Apr 15, 2020
@samartnik samartnik mentioned this issue Apr 15, 2020
Merged
32 tasks
@srirambv
Copy link
Contributor Author

Verification passed on Samsung Tab A with Android 9 running 1.7.100 x64 build

  • Verified no option for custom tabs in settings
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android-tablet-specific feature/global-settings Settings at browser level independent of shields settings OS/Android Fixes related to Android browser functionality QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
Android 1.7.x Release
Development

Successfully merging a pull request may close this issue.

Excluded custom tabs option from tablets brave/brave-core
2 participants
@kjozwiak @srirambv