-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display zero count on brave shield icon on "clean" sites #933
Labels
Comments
bsclifton
added
feature/shields
The overall Shields feature in Brave.
design
A design change, especially one which needs input from the design team
labels
Sep 3, 2018
The count was shown as 0 initially when nothing was blocked but then reverted here brave/browser-laptop@29acdac for brave/browser-laptop#7873. Not sure if this is still a valid? |
I think I prefer no 0 |
SGTM 😄 👍 |
bbondy
removed
design
A design change, especially one which needs input from the design team
feature/shields
The overall Shields feature in Brave.
suggestion
labels
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Carried over from brave/browser-laptop#11106
The text was updated successfully, but these errors were encountered: