-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promotions are fetched too often #9513
Labels
feature/rewards
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
QA Pass - Android ARM
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
32 tasks
Verified passed with
Verification passed on
Verification passed on
|
rebron
changed the title
Promotions are fetch too often
Promotions are fetched too often
Jul 21, 2020
emerick
added
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
labels
Aug 7, 2020
Verification passed on OnePlus 6T with Android 10 running 1.12.112 x64 build
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/rewards
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
QA Pass - Android ARM
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
We should have some cacheing in this area, so that we don't pull every time that you open a panel for example. We should store last fetch in preferences (
last_fetch.promotion
) and then when we get request for promotion fetch we check that preference and if's not older then 10min just return what we have in db. We also need to allow for this check to be removed if you pass is_testing setThe text was updated successfully, but these errors were encountered: