Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains loaded over IPFS are not detected for brave rewards #9631

Closed
RubenKelevra opened this issue May 5, 2020 · 2 comments · Fixed by brave/brave-core#8512
Closed

Domains loaded over IPFS are not detected for brave rewards #9631

RubenKelevra opened this issue May 5, 2020 · 2 comments · Fixed by brave/brave-core#8512

Comments

@RubenKelevra
Copy link

RubenKelevra commented May 5, 2020

Description

If a domain can be loaded over IPFS (DNSLink) the website is forwarded to the configured local gateway. In this case the domain looks like <domain>.ipns.localhost[:<port>]. While port might be any port or port 80 (not shown at all).

Steps to Reproduce

  1. open brave
  2. enable ipfs
  3. install a local ipfs client
  4. navigate to https://ipfs.io

Actual result:

Screenshot_20200505_212025

Expected result:

ipfs.io is a verified creator and should be identified.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 1.8.86 Chromium: 81.0.4044.129 (Official Build) unknown (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Linux
JavaScript | V8 8.1.307.31
Flash | (Disabled)
User Agent | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.129 Safari/537.36
Command Line | /usr/lib/brave-bin/brave --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --sync-url=https://no-thanks.invalid --enable-features=PasswordImport,WebUIDarkMode,AutoupgradeMixedContent,PassiveMixedContentWarning,MixedContentSiteSetting,SimplifyHttpsIndicator,DnsOverHttps --disable-features=AutofillServerCommunication,TextFragmentAnchor,VideoPlaybackQuality,LookalikeUrlNavigationSuggestionsUI,AllowPopupsDuringPageUnload,NotificationTriggers,AudioServiceOutOfProcess,SmsReceiver --flag-switches-begin --enable-features=PasswordImport,WebUIDarkMode,AutoupgradeMixedContent,PassiveMixedContentWarning,MixedContentSiteSetting,SimplifyHttpsIndicator,DnsOverHttps,BraveSync,DecodeJpeg420ImagesToYUV,DecodeLossyWebPImagesToYUV,ImpulseScrollAnimations,LegacyTLSEnforced,PaintHolding,PercentBasedScrolling,SyncSetupFriendlySettings --flag-switches-end --disable-webrtc-apm-in-audio-service
Executable Path | /usr/lib/brave-bin/brave
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Sep 2, 2020
@spylogsster spylogsster self-assigned this Apr 8, 2021
@spylogsster
Copy link

Show verified publishers for ipns:// domains only brave/brave-core#8512.

@stephendonner
Copy link

stephendonner commented Apr 20, 2021

Verified PASSED using

Brave 1.25.25 Chromium: 90.0.4430.72 (Official Build) nightly (x86_64)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS macOS Version 11.2.3 (Build 20D91)

Steps:

  1. new profile
  2. loaded ipns://ipfs.io
  3. clicked on Use a local node
  4. after ipns://ipfs.io loaded, clicked on the BAT logo in the URL bar

Confirmed site was listed as a verified creator, had a creator's tip banner, and verified I could tip them.

example example example
Screen Shot 2021-04-19 at 6 16 40 PM Screen Shot 2021-04-19 at 6 17 13 PM Screen Shot 2021-04-19 at 6 17 17 PM

Verification passed on

Brave | 1.25.57 Chromium: 90.0.4430.93 (Official Build) beta (64-bit)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2004 (Build 19041.985)

Confirmed site was listed as a nonverified creator in staging and verified in prod, had a creator's tip banner, and verified I could tip them.

example example example example example
image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants