You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're using the component installer (SpeedreaderWhitelist) where we should be using the SpeedreaderService. speedreader::Speedreader should be a base::Singleton and can be accessed inside the SpeedreaderService using Speedreader::GetInstance
SpeedreaderWhitelist should be SpeedreaderWhitelistInstaller`
kSpeedreaderEnabled doesn't appear to actually disable speedreader, it just removes the button (wasting cpu cycles and memory when it's off). It sort of turns it off with SpeedreaderTabHelper::UpdateActiveState, but that should use a pref listener like the button
explore ways to use chromium's css/html parsers instead of relying on third-party library that may be treating things differently
The text was updated successfully, but these errors were encountered:
Description
Follow up for brave/brave-core#5142
Documents comments left to address.
SpeedreaderWhitelist
) where we should be using the SpeedreaderService.speedreader::Speedreader
should be abase::Singleton
and can be accessed inside theSpeedreaderService
usingSpeedreader::GetInstance
SpeedreaderWhitelist
should be SpeedreaderWhitelistInstaller`kSpeedreaderEnabled
doesn't appear to actually disable speedreader, it just removes the button (wasting cpu cycles and memory when it's off). It sort of turns it off withSpeedreaderTabHelper::UpdateActiveState
, but that should use a pref listener like the buttonThe text was updated successfully, but these errors were encountered: