Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Brave Suggested sites don't display when Autocomplete of search is enabled #9811

Closed
rebron opened this issue May 17, 2020 · 2 comments

Comments

@rebron
Copy link
Collaborator

rebron commented May 17, 2020

Description

Brave Suggested sites don't display when Autocomplete of search is enabled

Steps to Reproduce

Turn on Autocomplete searches and URLs in brave://settings/privacy and notice that Brave Suggested Sites do not display, only the search autocomplete results.

Actual result:

No Brave Suggested Sites.

Expected result:

Brave Suggested sites per Test plan. #9572 (comment)

Reproduces how often:

Easily.

Brave version (brave://version info)

Brave 1.10.60 Chromium: 81.0.4044.138 (Official Build) beta (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Windows 10 OS Version 1909 (Build 18363.836)

Version/Channel Information:

  • Can you reproduce this issue with the current release?n/a
  • Can you reproduce this issue with the beta channel? Yes 1.10.x
  • Can you reproduce this issue with the dev channel? 1.10.x
  • Can you reproduce this issue with the nightly channel? Yes 1.11.x

Other Additional Information:

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". feature/settings feature/autocomplete labels Jun 26, 2020
@rebron rebron changed the title Brave Suggested sites don't display when Autocomplete of search is enabled [Desktop] Brave Suggested sites don't display when Autocomplete of search is enabled Jun 26, 2020
@rebron
Copy link
Collaborator Author

rebron commented Jun 26, 2020

cc: @bbondy We prioritized as p4. Please change if you feel differently.

@bbondy
Copy link
Member

bbondy commented Jun 26, 2020

I think this is the correct behavior so closing

@bbondy bbondy closed this as completed Jun 26, 2020
@rebron rebron removed feature/autocomplete feature/settings priority/P4 Planned work. We expect to get to it "soon". labels Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants