Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all base::ranges:: to std::ranges` that are breaking changes #43566

Open
cdesouza-chromium opened this issue Jan 29, 2025 · 0 comments · May be fixed by brave/brave-core#27384
Open

Migrate all base::ranges:: to std::ranges` that are breaking changes #43566

cdesouza-chromium opened this issue Jan 29, 2025 · 0 comments · May be fixed by brave/brave-core#27384
Assignees
@cdesouza-chromium
Labels
dev-concern OS/Desktop QA/No release-notes/exclude

Comments

@cdesouza-chromium
Copy link
Contributor

Description

Not all occurrences of base::ranges can be just replaced with std::ranges without build failures, and those should be merged first.
@cdesouza-chromium cdesouza-chromium self-assigned this Jan 29, 2025
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Jan 29, 2025
@cdesouza-chromium
Migrate std::range migration breakages - Pt.1
e73c281 
Upstream has abandoned its in-house implementation of `base::ranges`,
and all cases now merely alias back to the upstream implementation. This
has caused some build failures, as in certain cases the implementation
in `base` didn't quite match what was being done in `std`.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/7be06d9af3db3b022636d5f597353d9d89207427

commit 7be06d9af3db3b022636d5f597353d9d89207427
Author: Peter Kasting <pkasting@chromium.org>
Date:   Thu Jan 23 12:33:52 2025 -0800

    Make base::ranges equivalent to std::ranges.

    This prevents backsliding while rewriting the codebase to explicitly
    spell the latter.

    Bug: 386918226

Resolves brave/brave-browser#43566
@cdesouza-chromium cdesouza-chromium linked a pull request Jan 29, 2025 that will close this issue
Open
24 tasks
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Jan 30, 2025
@cdesouza-chromium
Migrate std::range migration breakages - Pt.1
fcb2489 
Upstream has abandoned its in-house implementation of `base::ranges`,
and all cases now merely alias back to the upstream implementation. This
has caused some build failures, as in certain cases the implementation
in `base` didn't quite match what was being done in `std`.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/7be06d9af3db3b022636d5f597353d9d89207427

commit 7be06d9af3db3b022636d5f597353d9d89207427
Author: Peter Kasting <pkasting@chromium.org>
Date:   Thu Jan 23 12:33:52 2025 -0800

    Make base::ranges equivalent to std::ranges.

    This prevents backsliding while rewriting the codebase to explicitly
    spell the latter.

    Bug: 386918226

Resolves brave/brave-browser#43566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdesouza-chromium cdesouza-chromium

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate std::range migration breakages - Pt.1 brave/brave-core
1 participant
@cdesouza-chromium