Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ad notification should not be stacked below panel #1904

Closed
srirambv opened this issue Nov 5, 2019 · 2 comments
Closed

Ad notification should not be stacked below panel #1904

srirambv opened this issue Nov 5, 2019 · 2 comments
Assignees
@Brandon-T
Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.14.1

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 5, 2019

Description:

Ad notification should not be stacked below panel

Steps to Reproduce

  1. Skip rewards onboarding
  2. Manually enable rewards
  3. Keep the rewards panel open
  4. Wait for the sample ad notification to show up, gets stacked behind the panel

Actual result:
Since this happens on sample ad chances are this will happen on acutal ad as wel if panel is open
image

Expected result:
Ads notification should always be on top.

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.13(19.11.5.20)

Device details:
All iPhones

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@srirambv srirambv added this to the 1.14 milestone Nov 5, 2019
@srirambv
Copy link
Contributor Author

srirambv commented Nov 6, 2019

Reproduces on iPad as well
image

@kylehickinson kylehickinson modified the milestones: 1.14, 1.15 Nov 6, 2019
@Brandon-T Brandon-T self-assigned this Nov 11, 2019
@Brandon-T Brandon-T mentioned this issue Nov 11, 2019
Merged
7 tasks
@jhreis jhreis modified the milestones: 1.15, 1.14.1 Dec 3, 2019
@srirambv
Copy link
Contributor Author

srirambv commented Dec 4, 2019 •
edited
Loading

Verification passed on iPhone XR with iOS 13.2 running 1.4.1 (19.12.4.2)

  • Verified ad notification is not stacked behind rewards panel
    image
  • Verified ad notification is not stacked behind shields panel
    image

Verification PASSED on iPhone 6s+ running iOS 12.4.1 using 1.14.1 (19.12.04.02)

  • ensured that the notification was in the foreground when Rewards/Shield panels are opened
  • ensured that you can still tap on the notifications without any issues

IMG_9952

IMG_9951

IMG_9950

Verification passed on iPad Pro with iOS 13.2 running 1.14.1(19.12.05.00)

  • Verified ad notification is not stacked behind rewards panel
    image
  • Verified ad notification is not stacked behind shields panel
    image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.14.1
Development

No branches or pull requests
5 participants
@kylehickinson @Brandon-T @kjozwiak @jhreis @srirambv