Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add "Delete All" functionality to History Controller #3723

Closed
soner-yuksel opened this issue May 25, 2021 · 1 comment · Fixed by #3703
Closed

Add "Delete All" functionality to History Controller #3723

soner-yuksel opened this issue May 25, 2021 · 1 comment · Fixed by #3703

Comments

@soner-yuksel
Copy link
Contributor

Description:

Currently, there is no "Delete Entire History" functionality on History page itself. Users should have to navigate Settings -> Shields & Privacy -> Clear Data and mark Browsing History and execute Clear Data now.

The idea is to add new simple way to clear entire History inside the page.

Actual result:

Only way is to clear the History on the page itself is to delete all entry one by one.

Expected result:

Add a "Delete All" bar button item on History Navigation bar and press it will show a action sheet alert for explainin the functionality and approval of the user.

Screenshot:

deleteAll

@srirambv
Copy link
Contributor

srirambv commented Aug 6, 2021

Verification passed on iPhone XR with iOS 13.5 running 1.30(21.8.5.11)

  • Verified clear history button is shown on history page
  • Verified clicking the trash bin warns the user about clearing history
  • Verified clicking on Clear History clears all the history entries
image image

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.30(21.8.5.11)

  • Verified clear history button is shown on history page
  • Verified clicking the trash bin warns the user about clearing history
  • Verified clicking on Clear History clears all the history entries
image image

Verification passed on iPad Pro with iOS 13.5 running 1.30(21.8.5.11)

  • Verified clear history button is shown on history page
  • Verified clicking the trash bin warns the user about clearing history
  • Verified clicking on Clear History clears all the history entries
image image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.