Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Handling truncated domains #552

Closed
jumde opened this issue Dec 3, 2018 · 4 comments
Closed

Handling truncated domains #552

jumde opened this issue Dec 3, 2018 · 4 comments
Assignees
@jumde @danishjafri88
Labels
enhancement Epic: Security priority/P4 Planned work. We expect to get to it "soon". QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include sec-high
Milestone
1.12

Comments

@jumde
Copy link
Contributor

jumde commented Dec 3, 2018 •
edited
Loading

From: https://github.com/brave/browser-ios/issues/1100

Test Plan:

  1. Navigate to http://random-test-domain.paypal.com/randompath - Verify that paypal.com is focussed in the address bar
  2. Navigate to http://random-test.paypal.com/randompath - Verify that random-test.paypal.com is focussed in the address bar

This issue was highlighted in the HindSight paper recently: https://www.securitee.org/files/hindsight_ccs2017.pdf
@jumde jumde added the security label Dec 3, 2018
@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Dec 3, 2018
@tildelowengrimm
Copy link

Preferred behavior:

  • right-align the TLD
  • highlight the ETLD+1

@jumde jumde self-assigned this Jan 22, 2019
@jumde jumde added the sec-high label Jan 28, 2019
@danishjafri88 danishjafri88 self-assigned this Feb 4, 2019
@jhreis jhreis added this to the 1.12 milestone Aug 8, 2019
@jhreis jhreis closed this as completed in f5d3d99 Aug 8, 2019
This was referenced Sep 5, 2019
Closed
Closed
Closed
@jumde
Copy link
Contributor Author

jumde commented Sep 8, 2019

@srirambv - added the test plan, let me know if you have any questions. cc: @danishjafri88

@srirambv
Copy link
Contributor

srirambv commented Sep 9, 2019

Verification passed on iPhone XR with 13.1 beta 2 running 1.12(19.09.07.03)
image

@kjozwiak
Copy link
Member

kjozwiak commented Sep 11, 2019 •
edited
Loading

Verification PASSED on iPad Air 3rd Generation iOS 13.1 running 1.12 (19.09.10.18):

Screen Shot 2019-09-11 at 12 09 19 AM

Screen Shot 2019-09-11 at 12 09 10 AM

Verification PASSED on iPhone 6s+ using iOS 12.4.1 running 1.12 (19.09.13.06):

IMG_9917
IMG_9916

@srirambv srirambv mentioned this issue Oct 3, 2019
Closed
This was referenced Nov 15, 2019
Closed
Merged
@jumde jumde mentioned this issue Jul 8, 2020
Merged
32 tasks
@jumde jumde mentioned this issue Oct 11, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jumde jumde

@danishjafri88 danishjafri88

Labels
enhancement Epic: Security priority/P4 Planned work. We expect to get to it "soon". QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include sec-high
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
6 participants
@tildelowengrimm @jumde @kjozwiak @jhreis @danishjafri88 @srirambv