Disable Clear browsing settings when in PB mode

[srirambv]

Description:

Disable Clear browsing settings when in PB mode otherwise leads to confusion similar to #605

Steps to Reproduce

1. Open Private tab
2. Open settings and clear private tab
3. All settings are shown and doesn't differentiate if its for normal or private tabs

Actual result:
Disable Clear browsing settings when in PB mode

Expected result:
Disable clear private data option when PB mode is switched on

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
All

Device details:
All

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

[kylehickinson]

By PB mode do you mean "Private Browsing Only" or just when you're currently in a private tab?

[srirambv]

During Private browsing only mode

[kylehickinson]

Turning on private only browsing doesn't erase your history for regular tabs (it even currently keeps your regular tabs—which is a different issue: #580). So the user could definitely still clear their private data when they're browsing private only mode. After they do it once though if they never turn off private only mode then there'd be no more data to remove.

[jhreis]

We will be renaming this copy to add more clarity, which should help with this confusion, but this specifically we do not currently want.