Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

The word "video" must be changed to "media" on any applicable pop-up message during "Playlist" onboarding #7675

Closed
hffvld opened this issue Jul 1, 2023 · 2 comments

Comments

@hffvld
Copy link
Collaborator

hffvld commented Jul 1, 2023

Description:

The word video must be changed to media on any applicable pop-up message during Playlist onboarding

Steps to Reproduce

  1. Launch Brave
  2. Open www.music.youtube.com > Find some Audio album or a song
  3. Observe the first Playlist onboarding pop-up message > Tap Discover How
  4. Observe the second pop-up message Introducing Brave Playlist > Observe the word video

Actual result:

It's confusing to see the word video when doing Playlist onboarding on a website like www.music.youtube.com with opened song, but not a video.

1 2 3 4
1 2 3 4

Expected result:

It would be nice to update the word video to media on any applicable pop-up message during Playlist onboarding since it's possible to add video and audio files to Brave Playlist.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.53 (23.6.23.14)
BraveCore: 1.53.102 (114.0.5735.133)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 14 [iOS 16.5.1]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@hkarmoush
Copy link
Contributor

can I take over on this? @iccub @vlad-hoff

@kylehickinson
Copy link
Collaborator

Im not sure if we are actually planning on making this change so best to leave it for now, @hkarmoush. Thanks though!

@iccub iccub closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants