Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

WebTorrent: Torrent server should be restricted to same origin #10012

Closed
feross opened this issue Jul 17, 2017 · 2 comments
Closed

WebTorrent: Torrent server should be restricted to same origin #10012

feross opened this issue Jul 17, 2017 · 2 comments

Comments

@feross
Copy link
Contributor

feross commented Jul 17, 2017

  • Did you search for similar issues before submitting this one? Yes.

  • Describe the issue you encountered:

another origin could make an XHR or fetch request to the localhost torrent server URL, if they could guess the server address + port + url, which isn't very hard through enumeration.

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master

  • Steps to reproduce:

    1. Open inspector on a webtorrent media viewer page.
    2. Select the <video> node and copy the URL.
    3. Make a fetch or XHR request from another domain and see that it is allowed.
  • Can this issue be consistently reproduced? Yes.

@feross
Copy link
Contributor Author

feross commented Jul 17, 2017

PR: #10011

@diracdeltas diracdeltas added this to the 0.17.17 (Release Channel) milestone Jul 17, 2017
@diracdeltas
Copy link
Member

adding to next release since it is a high impact security issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.