Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark cannot be moved to bookmark folder on bookmark toolbar #10101

Closed
luixxiul opened this issue Jul 24, 2017 · 13 comments
Closed

Bookmark cannot be moved to bookmark folder on bookmark toolbar #10101

luixxiul opened this issue Jul 24, 2017 · 13 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 24, 2017

Describe the issue you encountered: Bookmark cannot be moved to bookmark folder on bookmark toolbar.

bookmark

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version (revision SHA): 2ceca28

  • Steps to reproduce: Test that moving a bookmark into a folder by drag and drop on the bookmarks folder works

  • Actual result: it does not work

  • Expected result: it should work

  • Any related issues:

@luixxiul luixxiul added this to the 0.20.x (Nightly Channel) milestone Jul 24, 2017
@tblu
Copy link

tblu commented Jul 25, 2017

confirmed on win10, rev 4e46480

@NejcZdovc
Copy link
Contributor

@luixxiul can you please try it on the latest master? For me it's working, but it's hard to nail it 😃

@kiyomasa-slotet
Copy link

same issue happened.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    OS X 10.11.6

  • Brave Version (revision SHA):
    0.18.14

brave_bug2

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 7, 2017

@pullingour I'm not quite sure how this is the same one.

@kiyomasa-slotet
Copy link

kiyomasa-slotet commented Aug 7, 2017

@luixxiul Do I have to create a new issue?

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 7, 2017

@pullingour yes please, thanks.

@sjlehn
Copy link
Contributor

sjlehn commented Aug 7, 2017

@pullingour I just entered a defect for that #10323

@bsclifton
Copy link
Member

bsclifton commented Aug 7, 2017

@pullingour In your screenshot, it shows you drag to the .ca folder... Can you try this again, but this time click somewhere else (like inside the page)... then re-click the .ca folder?

I believe the issue is that the context menu didn't get re-rendered yet (with the new item inside). Once you force the app to re-create + show the menu again, it usually shows the correct menu

@kiyomasa-slotet
Copy link

@sjlehn Thanks! I'll post description and screenshot for #10323

@bsclifton I tried again, the same problem happened. I'll post another screenshot for #10323
This issue happen when I try drag and drop bookmark that top of folder only. Another bookmarks are fine. I will write more detailed explanation for #10323

@alexwykoff alexwykoff added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Aug 8, 2017
@alexwykoff
Copy link
Contributor

@luixxiul this needs comparison vs other browsers. the interaction makes sense for files but we need to compare vs browsers

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 9, 2017

This is the issue I reported:

bookmark

Actually this is a regression based on 0.18.14, so I think we don't need to do comparisons.

@luixxiul luixxiul added release/not-blocking and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. release/not-blocking labels Aug 9, 2017
@alexwykoff alexwykoff modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 15, 2017
@ghost
Copy link

ghost commented Aug 15, 2017

Removing from the milestone, and will be addressed when drag/drop in the browser is addressed with more focus.

@luixxiul
Copy link
Contributor Author

luixxiul commented Sep 4, 2017

This seems to have been fixed with 0.18.26. Assigning the milestone for QA

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.