Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

margin changes when payments is enabled and disabled #10153

Closed
luixxiul opened this issue Jul 26, 2017 · 2 comments
Closed

margin changes when payments is enabled and disabled #10153

luixxiul opened this issue Jul 26, 2017 · 2 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 26, 2017

Test plan

#10154 (comment)


Describe the issue you encountered: margin between the title wrapper and the content changes when payments is enabled and disabled.

margin

This is due to that margin is not offset when the element is styled with float.

  • Brave Version (revision SHA): master branch

  • Steps to reproduce:

    1. Open about:preferences#payments
    2. Enable and disable Payments
  • Actual result: the margin between the title wrapper and the content changes

  • Expected result: it should not change

  • Any related issues:

@luixxiul
Copy link
Contributor Author

fyi I referred this document (written in Japanese) to find the issue: http://kojika17.com/2012/08/margin-of-css.html

It is a thorough analysis on the relationship between margin and flex.

@luixxiul luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Sep 7, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Sep 7, 2017

Modified the milestone based on #10154 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.