Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Restructure paymentsTab with grid property #10236

Closed
luixxiul opened this issue Aug 1, 2017 · 3 comments
Closed

Restructure paymentsTab with grid property #10236

luixxiul opened this issue Aug 1, 2017 · 3 comments
Assignees
@luixxiul
Labels
feature/about-pages polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 1, 2017 •
edited
Loading

Test plan

#10238 (comment)

Describe the issue you encountered: Restructure paymentsTab with display:grid. It is more simple than using display:table.

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master

  • Extra QA steps:

    1. Open about:preferences#payments
    2. Enable payments
    3. Make sure the elements are aligned equally on both rows and columns
    4. Disable payments
    5. Make sure the switch is placed on the same place

  • Screenshot if needed:

    From:
    screenshot 2017-08-02 1 53 04

    To:
    screenshot 2017-08-02 13 34 17

    Please see the width of the pulldown and the textarea becomes equal.

  • Any related issues: Fix BEM naming on enabledContent.js #10146
@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. refactoring/aphrodite labels Aug 1, 2017
@luixxiul luixxiul self-assigned this Aug 1, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 1, 2017
This was referenced Aug 1, 2017
Merged
Closed
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Dec 27, 2017
Closed
35 tasks
This was referenced Jan 2, 2018
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jan 9, 2018 •
edited
Loading

This is still not fixed on Windows
image

@srirambv srirambv reopened this Jan 9, 2018
@luixxiul
Copy link
Contributor Author

luixxiul commented Jan 9, 2018

It's been fixed since quite a long time and the tab page has been worked on massively. Let me close this issue and open a new one to track the misalignment issue above.

@luixxiul luixxiul closed this as completed Jan 9, 2018
@luixxiul luixxiul mentioned this issue Jan 9, 2018
Closed
This was referenced Jan 22, 2018
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
@LaurenWags
Copy link
Member

Looks good on MacOS - #12572 will cover mis-alignment of 'auto-include' switch:
screen shot 2018-01-23 at 2 59 22 pm

This was referenced Jan 24, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jan 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/about-pages polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @kjozwiak @luixxiul @srirambv @LaurenWags