Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

bookmark name updates when you View Page Source #10372

Closed
LaurenWags opened this issue Aug 9, 2017 · 3 comments
Closed

bookmark name updates when you View Page Source #10372

LaurenWags opened this issue Aug 9, 2017 · 3 comments

Comments

@LaurenWags
Copy link
Member

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When you 'View Page Source' for a bookmarked page, the bookmark name updates to be view-source:

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS

  • Brave Version (revision SHA):
    Brave | 0.18.20
    rev | 60bb9e6
    Muon | 4.3.9

  • Steps to reproduce:

    1. Navigate to a non-bookmarked page.
    2. Bookmark the page to the Bookmark Toolbar.
    3. Right click on the page and select 'View Page Source'
  • Actual result:
    Bookmark name updates to be view-source:

  • Expected result:
    Bookmark name should not update.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

screen shot 2017-08-09 at 2 18 11 pm

  • Any related issues:
@LaurenWags LaurenWags added this to the 0.21.x (Nightly Channel) milestone Aug 9, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Aug 9, 2017

@NejcZdovc was this fixed with the split PR you merged recently?

@NejcZdovc
Copy link
Contributor

Yeah please test this on the latest master

@bsclifton
Copy link
Member

bsclifton commented Aug 9, 2017

Closing this out since it was fixed in master with site splitting (it was one of maybe 20 issues fixed 😄 )

Please re-open if the issue still happens in master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.