Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

need to toggle cookie control for some sites to display properly #10418

Closed
LaurenWags opened this issue Aug 10, 2017 · 3 comments
Closed

need to toggle cookie control for some sites to display properly #10418

LaurenWags opened this issue Aug 10, 2017 · 3 comments

Comments

@LaurenWags
Copy link
Member

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    In previous versions (0.17.x, 0.18.14, 0.18.20), sites used for testing like https://jsfiddle.net/bkf50r8v/13/ (and other jsfiddle sites in our test wiki) displayed normally with default shield settings. With 0.18.21, to get these sites to display properly you must change the cookie setting from 'Block 3rd party cookies' to something else and then back to 'Block 3rd party cookies'.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS

  • Brave Version (revision SHA):
    0.18.21

  • Steps to reproduce:

    1. Navigate to https://jsfiddle.net/bkf50r8v/13/ with default shield settings. (I was using a clean profile on 0.18.21)
    2. Notice right side of page is not displaying properly.
  • Actual result:
    Page does not display correctly with default shields. You have to toggle cookie setting to something else and then back to 'Block 3rd party cookies' (the original setting) to get it to display properly.

  • Expected result:
    page should display properly with default settings the first time you navigate to it.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    no

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    Actual:
    screen shot 2017-08-10 at 4 34 02 pm

Expected:
expected

  • Any related issues:
@luixxiul
Copy link
Contributor

luixxiul commented Aug 11, 2017

After allowing the 3rd party cookie once and resetting the setting, the issue is no longer reproduced for me.

@luixxiul
Copy link
Contributor

on devtool:

(index):92 Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
    at https://fiddle.jshell.net/bkf50r8v/13/show/:92:13
analytics.js Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
(index):92 Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
    at https://fiddle.jshell.net/bkf50r8v/13/show/light/:92:13
analytics.js Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
(index):92 Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
    at https://fiddle.jshell.net/bkf50r8v/13/show/light/:92:13
analytics.js Failed to load resource: net::ERR_BLOCKED_BY_CLIENT

@bsclifton
Copy link
Member

This seems to be fixed with the latest code- I'll close and we can retest when the next binary is ready 😄 Here's a screenshot
screen shot 2017-08-10 at 10 22 48 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants