Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

notification setting is retained w/o checking 'remember this decision' #10537

Closed
luixxiul opened this issue Aug 16, 2017 · 6 comments
Closed

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: notification setting is retained w/o checking 'remember this decision'.

@bsclifton
Copy link
Member

This behavior already exists- you have to reload the page in order to get prompted again. I'm going to remove milestone

@bsclifton bsclifton removed this from the 0.18.x Hotfix milestone Aug 16, 2017
@luixxiul
Copy link
Contributor Author

This behavior already exists- you have to reload the page in order to get prompted again

my muscle memory says no :-/ CC @alexwykoff @srirambv

@srirambv
Copy link
Collaborator

Unfortunately yes, this behavior is what it has always been there. I remember there was a discussion to change the behaviour from reloading the page each time when #5197 was logged but it hasn't been implemented yet. Same goes for deny full screen (#3887,#4574) access where the page becomes useless (scroll) unless the page is reloaded.

@luixxiul
Copy link
Contributor Author

so basically is this behavior what should actually be?

@srirambv
Copy link
Collaborator

Yes . But this behaviour has to be changed. Page reload should not be mandatory to get the prompt again

@bsclifton
Copy link
Member

Definitely needs to be fixed- thanks for capturing @luixxiul 😄 But yeah... per the above, it has always been this way (so it's not a regression)

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants