Three-finger "Look up" tap should work

[shamrin]

OS X supports three-finger "Look up" tap to look up words in a dictionary. Very useful when learning languages, for example. Unfortunately it doesn't work in Brave.

(Look up could also be invoked by cmd-ctrl-d.)

If you are not familiar with this feature, here it is in Google Chrome:

Version: 0.8.0
Electron: 0.36.8
libchromiumcontent: 47.0.2526.110
Channel: dev
OS X 10.11

Some probably related bugs:

• OS X dictionary doesn't work atom/atom#441
• Three finger tap for definitions doesn't work on OS X  atom/atom#5967
• https://bugzilla.mozilla.org/show_bug.cgi?id=1212527

[shamrin]

It seems to be a bug with Electron <webview>. I've submitted an issue: electron/electron#4772

[cndouglas]

Since #1627 (Look Up in the context menu) has already been implemented, we just need Brave to recognize the three finger gesture.

[cndouglas]

Update: With the current master (rev b288e18, 0.13.0 dev), now the Dictionary app opens with the search term "http". This behavior probably changed with Chromium 54.

[darkdh]

With chromium54 change (since 0.13.0), three finger tap or control + command + d will open a empty Dictionary.app but still needs a fix.
I believe this is what @bbondy discovered in #7043 and it is not limited in input field.

[bbondy]

I was definitely using the Lookup option from the context menu, so it could be I was doing something wrong at the time in addition to that, or using a wrong build somehow or something like that, or an intermittent bug.

[darkdh]

will be fixed in 0.13.3 by
https://chromium.googlesource.com/chromium/src.git/+/330ba4235e6b32ccad99d48427bc8b7b2df16130