Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Publisher entry jumps position when enabled/disabled #10716

Closed
srirambv opened this issue Aug 30, 2017 · 0 comments
Closed

Publisher entry jumps position when enabled/disabled #10716

srirambv opened this issue Aug 30, 2017 · 0 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Aug 30, 2017

Test plan

  1. Enable payments,
  2. disable auto-include switch
  3. Visit sites to fill up ledger table
  4. Enable/Disable publisher switch,
  5. Make sure enabling it should move the publisher to the top of the list
  6. Make sure publisher position does not jump around

  • Actual result:
    See attached screenshot

  • Expected result:
    If all publishers are disabled then enabling it should move the publisher to the top of the list. If publisher is enabled and then disabled based on other publishers state it should either remain in the same position or be listed right after the enabled one

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Publisher entry jumps position when enabled/disabled

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):

Brave 0.19.3
rev 0adbd61
Muon 4.4.1
  • Steps to reproduce:

    1. Enable payments, disable auto-include switch
    2. Visit sites to fill up ledger table
    3. Enable/Disable publisher switch, publisher position jumps around
  • Actual result:
    See attached screenshot

  • Expected result:
    If all publishers are disabled then enabling it should move the publisher to the top of the list. If publisher is enabled and then disabled based on other publishers state it should either remain in the same position or be listed right after the enabled one

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes. happens on release build as well

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    publishers

  • Any related issues:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants