Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

HTTPSe, domain: larryreznick.com #11022

Closed
lukemulks opened this issue Sep 20, 2017 · 3 comments
Closed

HTTPSe, domain: larryreznick.com #11022

lukemulks opened this issue Sep 20, 2017 · 3 comments

Comments

@lukemulks
Copy link
Collaborator

Description

Reported from community.brave.com: https://community.brave.com/t/no-https-upgrade-on-insecure-sight-s-how-come/7897/6

The larryreznick.com domain has an SSL cert, and can be manually overridden to upgrade the connection to https, but HTTPSe is loading the insecure connection by default.

I've been able to repro in Windows.

Steps to Reproduce

  1. Go to larryreznick.com w/httpse enabled
  2. Note http:// connection
  3. Override by hard coding https:// in the url.
  4. https connection loads for the domain
    Actual result:

http:// connection loads by default, w/HTTPSe enabled.

Expected result:
https connection should load.

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

7ab85e9

Additional Information

@diracdeltas as an FYI - I've taken a look at the source code and it appears to be a wordpress-hosted domain, with mixed http:// https:// and protocol relative urls for page resources. Not sure if it is related, but the urls I'm referring to are in the head section of the page source.

@lukemulks lukemulks changed the title HTTPS Everywhere, domain: larryreznick.com HTTPSe, domain: larryreznick.com Sep 20, 2017
@diracdeltas
Copy link
Member

HTTPS Everywhere does not upgrade every HTTP connection to HTTPS, only when there is an applicable rule for it. We do not maintain the rulesets ourselves so this needs to be filed with https://github.com/efforg/https-everywhere.

@bsclifton
Copy link
Member

bsclifton commented Sep 20, 2017

@lukemulks @diracdeltas we also may need to update our rules- looking at Jenkins, the last time we ran https://github.com/brave/https-everywhere-builder/ and pushed to prod was July 25th

@diracdeltas
Copy link
Member

closing this as it should be an upstream issue, and the ruleset update issue is covered by #11598

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants