Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL Text is way low compared to URL elements #11032

Closed
srirambv opened this issue Sep 20, 2017 · 6 comments
Closed

URL Text is way low compared to URL elements #11032

srirambv opened this issue Sep 20, 2017 · 6 comments

Comments

@srirambv
Copy link
Collaborator

Description

URL Test is way low compared to URL elements

Actual result:
image

Expected result:
image

Reproduces how often: [What percentage of the time does it reproduce?]
Yes

Brave Version

Name Version
Brave 0.19.7
rev c8481a9
Muon 4.4.16

Additional Information

#5624,#6505
cc: @luixxiul @bradleyrichter

@srirambv srirambv added this to the 0.20.x (Developer Channel) milestone Sep 20, 2017
@luixxiul
Copy link
Contributor

is this reproducible only on Windows?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Sep 20, 2017
@srirambv srirambv changed the title URL Test is way low compared to URL elements URL Text is way low compared to URL elements Sep 20, 2017
@srirambv
Copy link
Collaborator Author

This is on Ubuntu VM
image

@luixxiul luixxiul removed OS/unix-like/linux OS/Windows needs-info Another team member needs information from the PR/issue opener. labels Sep 20, 2017
@luixxiul
Copy link
Contributor

@srirambv is it also a regression?

@luixxiul
Copy link
Contributor

luixxiul commented Sep 20, 2017

also please try with tall alphabets like h ie eg https://github.com or https://brave.com/Payments_FAQ.html and see if it is still really low and not high unnaturally.

The red line goes through the center of l on the screenshot, so modifying the placement would cause another issue on other cases. I'm inclined to add wontfix since this is ultimately a matter of alphabets and the font set which has the different height characters. So you wouldn't have that kind of height issue on Japanese for example:

clipboard01

There the characters are aligned to the center of the URL bar.

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Sep 20, 2017
@ghost ghost added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
@ghost ghost assigned srirambv Sep 26, 2017
@ghost ghost removed this from the 0.20.x (Developer Channel) milestone Sep 26, 2017
@srirambv
Copy link
Collaborator Author

Looks much better on the latest build
image

@srirambv
Copy link
Collaborator Author

This is how visiting google.com looks on 0.19.20
image

@luixxiul luixxiul added wontfix and removed needs-info Another team member needs information from the PR/issue opener. regression priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). labels Sep 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants