Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger transfer PDF opens another window #11173

Closed
NejcZdovc opened this issue Sep 27, 2017 · 4 comments
Closed

Ledger transfer PDF opens another window #11173

NejcZdovc opened this issue Sep 27, 2017 · 4 comments

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 27, 2017

Test plan

  1. Clear the browser's profile
  2. Open about:preferences#payments
  3. Create wallet
  4. Run npm run add-simulated-payment-history
  5. Click on one transaction
  6. Make sure there shouldn't be any additional window and brave should work.

Description

When you open transaction from ledger, you get additional window and brave becomes unresponsive.

Steps to Reproduce

  1. Create wallet
  2. Generate some transactions
  3. Click on one transaction

Actual result:

image

Expected result:
There shouldn't be any additional window and brave should work.
Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

Brave: 0.19.20
rev: ec880d0
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64

Reproducible on current live release:

Yes

Additional Information

#10691 (comment)

@NejcZdovc
Copy link
Contributor Author

After some digging I found out that we actually open this new window and save dialog modal, which is hidden behind this new window. So the only thing here to do is don't show this window from the start

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Sep 27, 2017

For some reason window is always opening, even when show is set to false . What I did to solve it is basically set width and height to 0. Now everything is working again

@bsclifton
Copy link
Member

@NejcZdovc great find! That is always a small detail that annoyed me but I hadn't taken the time to create an issue 😄

@bsclifton
Copy link
Member

Since this has been the behavior for several releases, I'm going to remove release/blocking

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.