You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Make sure there shouldn't be any additional window and brave should work.
Description
When you open transaction from ledger, you get additional window and brave becomes unresponsive.
Steps to Reproduce
Create wallet
Generate some transactions
Click on one transaction
Actual result:
Expected result:
There shouldn't be any additional window and brave should work. Reproduces how often: [What percentage of the time does it reproduce?]
Brave Version
about:brave info:
Brave: 0.19.20
rev: ec880d0
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64
After some digging I found out that we actually open this new window and save dialog modal, which is hidden behind this new window. So the only thing here to do is don't show this window from the start
For some reason window is always opening, even when show is set to false . What I did to solve it is basically set width and height to 0. Now everything is working again
Test plan
npm run add-simulated-payment-history
Description
When you open transaction from ledger, you get additional window and brave becomes unresponsive.
Steps to Reproduce
Actual result:
Expected result:
There shouldn't be any additional window and brave should work.
Reproduces how often: [What percentage of the time does it reproduce?]
Brave Version
about:brave info:
Brave: 0.19.20
rev: ec880d0
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64
Reproducible on current live release:
Yes
Additional Information
#10691 (comment)
The text was updated successfully, but these errors were encountered: